Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: chrome/browser/prefs/pref_notifier_impl.cc

Issue 10559052: Split mode incognito extension can get misleading pref changed events from regular mode (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/pref_notifier_impl.cc
diff --git a/chrome/browser/prefs/pref_notifier_impl.cc b/chrome/browser/prefs/pref_notifier_impl.cc
index 3c23879ee06677892856a6f8c514f5fb9e665444..0b70c44616b4646518c916d900c7361fb167b8df 100644
--- a/chrome/browser/prefs/pref_notifier_impl.cc
+++ b/chrome/browser/prefs/pref_notifier_impl.cc
@@ -4,6 +4,7 @@
#include "chrome/browser/prefs/pref_notifier_impl.h"
+#include "base/logging.h"
Bernhard Bauer 2012/06/19 01:12:56 This doesn't seem necessary.
#include "base/stl_util.h"
#include "chrome/browser/prefs/pref_service.h"
#include "chrome/common/chrome_notification_types.h"
@@ -102,6 +103,7 @@ void PrefNotifierImpl::FireObservers(const std::string& path) {
NotificationObserverList::Iterator it(*(observer_iterator->second));
content::NotificationObserver* observer;
+
while ((observer = it.GetNext()) != NULL) {
observer->Observe(chrome::NOTIFICATION_PREF_CHANGED,
content::Source<PrefService>(pref_service_),

Powered by Google App Engine
This is Rietveld 408576698