Split mode incognito extension can get misleading pref changed events from regular mode

chrome/browser/prefs/pref_notifier_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/prefs/pref_notifier_impl.h"
 
+#include "base/logging.h"

[Bernhard Bauer, 2012/06/19 01:12:56]

This doesn't seem necessary.

 #include "base/stl_util.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_service.h"
 
 PrefNotifierImpl::PrefNotifierImpl()
     : pref_service_(NULL) {
 }
 
@@ skipping 78 matching lines @@
   if (!pref_service_->FindPreference(path.c_str()))
     return;
 
   const PrefObserverMap::iterator observer_iterator =
       pref_observers_.find(path);
   if (observer_iterator == pref_observers_.end())
     return;
 
   NotificationObserverList::Iterator it(*(observer_iterator->second));
   content::NotificationObserver* observer;
+
   while ((observer = it.GetNext()) != NULL) {
     observer->Observe(chrome::NOTIFICATION_PREF_CHANGED,
                       content::Source<PrefService>(pref_service_),
                       content::Details<const std::string>(&path));
   }
 }
 
 void PrefNotifierImpl::SetPrefService(PrefService* pref_service) {
   DCHECK(pref_service_ == NULL);
   pref_service_ = pref_service;
 }