lib/dom/scripts/generator.py - Issue 10548065: Revert "Fix DataView constructor and byte accessors."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/dom/scripts/generator.py

Issue 10548065: Revert "Fix DataView constructor and byte accessors." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/dom/scripts/generator.py

diff --git a/lib/dom/scripts/generator.py b/lib/dom/scripts/generator.py

index 886d8e02034d4e75e4d0d24ac766f930662415fd..8ef1ad14494adcaf092dd03508b3cf3336d61ee3 100644

--- a/lib/dom/scripts/generator.py

+++ b/lib/dom/scripts/generator.py

@@ -275,6 +275,8 @@ def AnalyzeConstructor(interface):

return map(lambda arg: _DartArg([arg], interface, True),

func_value.arguments)

+ if 'CustomConstructor' in interface.ext_attrs:

+ return None

if 'Constructor' in interface.ext_attrs:

name = None

func_value = interface.ext_attrs.get('Constructor')

@@ -711,8 +713,6 @@ _idl_type_registry = {

'boolean': PrimitiveIDLTypeInfo('boolean', dart_type='bool', native_type='bool',

webcore_getter_name='hasAttribute',

webcore_setter_name='setBooleanAttribute'),

- 'byte': PrimitiveIDLTypeInfo('byte', dart_type='int', native_type='int'),

- 'octet': PrimitiveIDLTypeInfo('octet', dart_type='int', native_type='int'),

'short': PrimitiveIDLTypeInfo('short', dart_type='int', native_type='int'),

'unsigned short': PrimitiveIDLTypeInfo('unsigned short', dart_type='int',

native_type='int'),

« no previous file with comments | « lib/dom/idl/dart/dart.idl ('k') | lib/dom/scripts/systemnative.py » ('j') | no next file with comments »