lib/dom/scripts/systemnative.py - Issue 10548065: Revert "Fix DataView constructor and byte accessors."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/dom/scripts/systemnative.py

Issue 10548065: Revert "Fix DataView constructor and byte accessors." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/dom/scripts/systemnative.py

diff --git a/lib/dom/scripts/systemnative.py b/lib/dom/scripts/systemnative.py

index ca0598c60b2b2753d8f60a12a0640dbb5a219951..afb1c3e30613ddb91bc90f923d246f7652f9cde5 100644

--- a/lib/dom/scripts/systemnative.py

+++ b/lib/dom/scripts/systemnative.py

@@ -255,7 +255,7 @@ class NativeImplementationGenerator(systembase.BaseGenerator):

if constructor_info:

self._EmitFactoryProvider(self._interface.id, constructor_info)

- if 'CustomConstructor' in self._interface.ext_attrs:

+ if constructor_info is None:

# We have a custom implementation for it.

self._cpp_declarations_emitter.Emit(

'\n'

« no previous file with comments | « lib/dom/scripts/generator.py ('k') | lib/dom/templates/html/frog/factoryprovider_DataView.darttemplate » ('j') | no next file with comments »