Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 10546158: Remove --default-device-scale-factor (Closed)

Created:
8 years, 6 months ago by oshima
Modified:
8 years, 6 months ago
Reviewers:
flackr, sky, Rick Byers
CC:
chromium-reviews, ben+watch_chromium.org
Visibility:
Public.

Description

Remove --default-device-scale-factor because chrome now gets scale factor from device. Add --force-device-scale-factor instead to override it. Remove obsolete comment in resource bundle. BUG=none TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=142163

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -31 lines) Patch
M chrome/browser/about_flags.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/monitor_manager.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M ui/aura/monitor_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/resource/resource_bundle_aurax11.cc View 1 2 chunks +2 lines, -5 lines 0 comments Download
M ui/base/ui_base_switches.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ui_base_switches.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M ui/gfx/display.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/gfx/display.cc View 3 chunks +18 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
oshima
Rick, Rob, can one of you review this first? http://codereview.chromium.org/10546158/diff/2001/ui/aura/monitor_manager.cc File ui/aura/monitor_manager.cc (right): http://codereview.chromium.org/10546158/diff/2001/ui/aura/monitor_manager.cc#newcode35 ui/aura/monitor_manager.cc:35: ...
8 years, 6 months ago (2012-06-14 00:58:42 UTC) #1
Rick Byers
Thanks Oshima. Please update about_flags.cc too - it still references --default-device-scale-factor http://codereview.chromium.org/10546158/diff/2001/ui/aura/monitor_manager.h File ui/aura/monitor_manager.h (right): ...
8 years, 6 months ago (2012-06-14 01:15:54 UTC) #2
sadrul
On 2012/06/14 01:15:54, Rick Byers wrote: > Thanks Oshima. > Please update about_flags.cc too - ...
8 years, 6 months ago (2012-06-14 01:20:13 UTC) #3
oshima
thanks. comment updated. updated flags and login code. PTAL.
8 years, 6 months ago (2012-06-14 01:48:05 UTC) #4
flackr
LGTM
8 years, 6 months ago (2012-06-14 01:56:58 UTC) #5
Rick Byers
lgtm
8 years, 6 months ago (2012-06-14 02:04:35 UTC) #6
oshima
+sky for OWNERS review
8 years, 6 months ago (2012-06-14 15:27:51 UTC) #7
sky
LGTM
8 years, 6 months ago (2012-06-14 15:50:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/10546158/8001
8 years, 6 months ago (2012-06-14 16:02:53 UTC) #9
commit-bot: I haz the power
8 years, 6 months ago (2012-06-14 17:00:21 UTC) #10
Try job failure for 10546158-8001 (retry) on linux_rel for step "net_unittests".
It's a second try, previously, step "net_unittests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Powered by Google App Engine
This is Rietveld 408576698