Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 10546147: ash: Fix the border colors in the uber-tray popup. (Closed)

Created:
8 years, 6 months ago by sadrul
Modified:
8 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, ben+watch_chromium.org
Visibility:
Public.

Description

ash: Fix the border colors in the uber-tray popup. The border between items in the popup should be light gray, and the top-border of the 'special row' in the popup should not be a solid thick border. BUG=130104, 132175 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141956

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : merge-tot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -5 lines) Patch
M ash/system/tray/system_tray_bubble.cc View 1 1 chunk +40 lines, -2 lines 0 comments Download
M ash/system/tray/tray_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_views.cc View 1 2 2 chunks +30 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sadrul
8 years, 6 months ago (2012-06-13 15:20:23 UTC) #1
sky
http://codereview.chromium.org/10546147/diff/1/ash/system/tray/system_tray_bubble.cc File ash/system/tray/system_tray_bubble.cc (right): http://codereview.chromium.org/10546147/diff/1/ash/system/tray/system_tray_bubble.cc#newcode45 ash/system/tray/system_tray_bubble.cc:45: const views::View* parent = view.parent(); Do you really ever ...
8 years, 6 months ago (2012-06-13 16:22:35 UTC) #2
sadrul
http://codereview.chromium.org/10546147/diff/1/ash/system/tray/system_tray_bubble.cc File ash/system/tray/system_tray_bubble.cc (right): http://codereview.chromium.org/10546147/diff/1/ash/system/tray/system_tray_bubble.cc#newcode45 ash/system/tray/system_tray_bubble.cc:45: const views::View* parent = view.parent(); On 2012/06/13 16:22:35, sky ...
8 years, 6 months ago (2012-06-13 16:39:20 UTC) #3
sadrul
On 2012/06/13 16:39:20, sadrul wrote: > http://codereview.chromium.org/10546147/diff/1/ash/system/tray/system_tray_bubble.cc > File ash/system/tray/system_tray_bubble.cc (right): > > http://codereview.chromium.org/10546147/diff/1/ash/system/tray/system_tray_bubble.cc#newcode45 > ...
8 years, 6 months ago (2012-06-13 17:13:11 UTC) #4
sky
8 years, 6 months ago (2012-06-13 20:11:00 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698