Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 10546116: gtk: Extract event functions into event_utils module. (Closed)

Created:
8 years, 6 months ago by tfarina
Modified:
8 years, 6 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Visibility:
Public.

Description

gtk: Extract event functions into event_utils module. This now matches with chrome/browser/ui/cocoa/event_utils.* and chrome/browser/ui/views/event_utils.* R=erg@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142207

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -124 lines) Patch
M chrome/browser/ui/gtk/avatar_menu_bubble_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/back_forward_button_gtk.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/gtk/browser_toolbar_gtk.cc View 3 chunks +4 lines, -3 lines 0 comments Download
A chrome/browser/ui/gtk/event_utils.h View 1 chunk +29 lines, -0 lines 0 comments Download
A chrome/browser/ui/gtk/event_utils.cc View 1 chunk +44 lines, -0 lines 0 comments Download
A + chrome/browser/ui/gtk/event_utils_unittest.cc View 3 chunks +17 lines, -9 lines 0 comments Download
M chrome/browser/ui/gtk/global_history_menu.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/gtk_util.h View 2 chunks +0 lines, -16 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_util.cc View 5 chunks +0 lines, -37 lines 0 comments Download
D chrome/browser/ui/gtk/gtk_util_unittest.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M chrome/browser/ui/gtk/infobars/confirm_infobar_gtk.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/infobars/link_infobar_gtk.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/menu_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/gtk/reload_button_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
tfarina
8 years, 6 months ago (2012-06-12 01:05:38 UTC) #1
Elliot Glaysher
lgtm
8 years, 6 months ago (2012-06-12 16:35:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/10546116/6001
8 years, 6 months ago (2012-06-14 13:51:02 UTC) #3
commit-bot: I haz the power
Try job failure for 10546116-6001 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 6 months ago (2012-06-14 15:48:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/10546116/6001
8 years, 6 months ago (2012-06-14 16:00:26 UTC) #5
commit-bot: I haz the power
Try job failure for 10546116-6001 (retry) on linux_rel for step "net_unittests". It's a second try, ...
8 years, 6 months ago (2012-06-14 16:48:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/10546116/6001
8 years, 6 months ago (2012-06-14 17:03:21 UTC) #7
commit-bot: I haz the power
Try job failure for 10546116-6001 (retry) on win_rel for step "runhooks". It's a second try, ...
8 years, 6 months ago (2012-06-14 17:17:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/10546116/6001
8 years, 6 months ago (2012-06-14 18:26:40 UTC) #9
commit-bot: I haz the power
8 years, 6 months ago (2012-06-14 19:49:37 UTC) #10
Change committed as 142207

Powered by Google App Engine
This is Rietveld 408576698