Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6677)

Unified Diff: chrome/browser/ui/gtk/gtk_util.cc

Issue 10546116: gtk: Extract event functions into event_utils module. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/gtk/gtk_util.h ('k') | chrome/browser/ui/gtk/gtk_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/gtk/gtk_util.cc
diff --git a/chrome/browser/ui/gtk/gtk_util.cc b/chrome/browser/ui/gtk/gtk_util.cc
index 9787664ca420381e70592495887f2297ac90457d..cd66dbce85ba4a1905b4313ccae57372ef8afc96 100644
--- a/chrome/browser/ui/gtk/gtk_util.cc
+++ b/chrome/browser/ui/gtk/gtk_util.cc
@@ -20,7 +20,6 @@
#include "chrome/browser/autocomplete/autocomplete_classifier.h"
#include "chrome/browser/autocomplete/autocomplete_match.h"
#include "chrome/browser/browser_process.h"
-#include "chrome/browser/event_disposition.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/profiles/profile_info_cache.h"
#include "chrome/browser/profiles/profile_manager.h"
@@ -35,7 +34,6 @@
#include "googleurl/src/gurl.h"
#include "grit/theme_resources.h"
#include "grit/theme_resources_standard.h"
-#include "ui/base/events.h"
#include "ui/base/gtk/gtk_compat.h"
#include "ui/base/gtk/gtk_hig_constants.h"
#include "ui/base/gtk/gtk_screen_util.h"
@@ -50,7 +48,6 @@
// These conflict with base/tracked_objects.h, so need to come last.
#include <gdk/gdkx.h> // NOLINT
-#include <gtk/gtk.h> // NOLINT
using content::RenderWidgetHost;
using content::WebContents;
@@ -294,28 +291,6 @@ GtkWidget* GetBrowserWindowFocusedWidget(BrowserWindow* window) {
} // namespace
-namespace event_utils {
-
-// TODO(shinyak) This function will be removed after refactoring.
-WindowOpenDisposition DispositionFromGdkState(guint state) {
- int event_flags = EventFlagsFromGdkState(state);
- return browser::DispositionFromEventFlags(event_flags);
-}
-
-int EventFlagsFromGdkState(guint state) {
- int flags = 0;
- flags |= (state & GDK_LOCK_MASK) ? ui::EF_CAPS_LOCK_DOWN : 0;
- flags |= (state & GDK_CONTROL_MASK) ? ui::EF_CONTROL_DOWN : 0;
- flags |= (state & GDK_SHIFT_MASK) ? ui::EF_SHIFT_DOWN : 0;
- flags |= (state & GDK_MOD1_MASK) ? ui::EF_ALT_DOWN : 0;
- flags |= (state & GDK_BUTTON1_MASK) ? ui::EF_LEFT_MOUSE_BUTTON : 0;
- flags |= (state & GDK_BUTTON2_MASK) ? ui::EF_MIDDLE_MOUSE_BUTTON : 0;
- flags |= (state & GDK_BUTTON3_MASK) ? ui::EF_RIGHT_MOUSE_BUTTON : 0;
- return flags;
-}
-
-} // namespace event_utils
-
namespace gtk_util {
GtkWidget* CreateLabeledControlsGroup(std::vector<GtkWidget*>* labels,
@@ -929,18 +904,6 @@ void SuppressDefaultPainting(GtkWidget* container) {
G_CALLBACK(PaintNoBackground), NULL);
}
-WindowOpenDisposition DispositionForCurrentButtonPressEvent() {
- GdkEvent* event = gtk_get_current_event();
- if (!event) {
- NOTREACHED();
- return NEW_FOREGROUND_TAB;
- }
-
- guint state = event->button.state;
- gdk_event_free(event);
- return event_utils::DispositionFromGdkState(state);
-}
-
bool GrabAllInput(GtkWidget* widget) {
guint time = gtk_get_current_event_time();
« no previous file with comments | « chrome/browser/ui/gtk/gtk_util.h ('k') | chrome/browser/ui/gtk/gtk_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698