Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 10546104: Make IsTriggerableEvent take Event objects and use it to verify whether tap events should trigger. (Closed)

Created:
8 years, 6 months ago by flackr
Modified:
8 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, sadrul
Visibility:
Public.

Description

Make IsTriggerableEvent take Event objects and use it to verify whether tap events should trigger. BUG=131184, 131200 TEST=Click on a bookmark folder button, it should not try / prompt to open all of the links in the folder. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141664

Patch Set 1 #

Patch Set 2 : Pass Event to ShouldEnterPushedState. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -40 lines) Patch
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 2 chunks +14 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/event_utils.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/event_utils.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/wrench_menu.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/wrench_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/button_dropdown.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/button_dropdown.cc View 1 1 chunk +7 lines, -5 lines 0 comments Download
M ui/views/controls/button/custom_button.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/button/custom_button.cc View 3 chunks +9 lines, -5 lines 0 comments Download
M ui/views/controls/menu/menu_delegate.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/controls/menu/menu_delegate.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M ui/views/controls/menu/menu_model_adapter.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/menu_model_adapter.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
flackr
We were using IsTriggerable event to prevent clicks from activating the OpenAll behaviour on bookmark ...
8 years, 6 months ago (2012-06-11 19:41:36 UTC) #1
sky
LGTM
8 years, 6 months ago (2012-06-11 20:22:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/10546104/1
8 years, 6 months ago (2012-06-11 21:42:10 UTC) #3
commit-bot: I haz the power
Try job failure for 10546104-1 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 6 months ago (2012-06-11 22:41:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/10546104/7002
8 years, 6 months ago (2012-06-12 14:13:59 UTC) #5
commit-bot: I haz the power
8 years, 6 months ago (2012-06-12 15:44:28 UTC) #6
Change committed as 141664

Powered by Google App Engine
This is Rietveld 408576698