chrome/browser/ui/views/event_utils.cc - Issue 10546104: Make IsTriggerableEvent take Event objects and use it to verify whether tap events should trigger.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/event_utils.cc

Issue 10546104: Make IsTriggerableEvent take Event objects and use it to verify whether tap events should trigger. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Pass Event to ShouldEnterPushedState. Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/event_utils.cc

diff --git a/chrome/browser/ui/views/event_utils.cc b/chrome/browser/ui/views/event_utils.cc

index f396f548ced4d2a203bf03d807b1d2ac4c7450f7..b01015552b18dfcaf378816272de39e49df831ec 100644

--- a/chrome/browser/ui/views/event_utils.cc

+++ b/chrome/browser/ui/views/event_utils.cc

@@ -8,8 +8,9 @@

namespace event_utils {

-bool IsPossibleDispositionEvent(const views::MouseEvent& event) {

- return event.IsLeftMouseButton() || event.IsMiddleMouseButton();

+bool IsPossibleDispositionEvent(const views::Event& event) {

+ return event.IsMouseEvent() && (event.flags() &

+ (ui::EF_LEFT_MOUSE_BUTTON | ui::EF_RIGHT_MOUSE_BUTTON));

}

} // namespace event_utils

« no previous file with comments | « chrome/browser/ui/views/event_utils.h ('k') | chrome/browser/ui/views/wrench_menu.h » ('j') | no next file with comments »