This one is a test specific API and can be moved to window.internals.

This one is a test specific API and can be moved to window.internals.

Webkit Bug - 
https://bugs.webkit.org/show_bug.cgi?id=84406

(Sending this out for silverroots(kaustubh.ra@gmail.com)

BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141631

[darin (slow to review), 2012-06-11 19:12:13]

LGTM

On Mon, Jun 11, 2012 at 11:45 AM, <sail@chromium.org> wrote:

> Reviewers: silverroots, darin, brettw,
>
> Description:
> This one is a test specific API and can be moved to window.internals.
>
> Webkit Bug -
>
https://bugs.webkit.org/show_**bug.cgi?id=84406<https://bugs.webkit.org/show_...
>
> (Sending this out for
silverroots(kaustubh.ra@gmail.**com<kaustubh.ra@gmail.com>
> )
>
> BUG=
> TEST=
>
>
> Please review this at
https://chromiumcodereview.**appspot.com/10546100/<https://chromiumcodereview...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M webkit/glue/webkit_glue.h
>  M webkit/glue/webkit_glue.cc
>
>
> Index: webkit/glue/webkit_glue.cc
> diff --git a/webkit/glue/webkit_glue.cc b/webkit/glue/webkit_glue.cc
> index 2477e230942784d465b3a93494d3ae**b78be216e8..**
> 57ecfc428fc7fe7b791d21e366fd01**10d0305510 100644
> --- a/webkit/glue/webkit_glue.cc
> +++ b/webkit/glue/webkit_glue.cc
> @@ -137,17 +137,6 @@ string16 DumpRenderer(WebFrame* web_frame) {
>   return web_frame->renderTreeAsText();
>  }
>
> -bool CounterValueForElementById(**WebFrame* web_frame, const
> std::string& id,
> -                                string16* counter_value) {
> -  WebString result =
> -      web_frame->**counterValueForElementById(**WebString::fromUTF8(id));
> -  if (result.isNull())
> -    return false;
> -
> -  *counter_value = result;
> -  return true;
> -}
> -
>  int PageNumberForElementById(**WebFrame* web_frame,
>                              const std::string& id,
>                              float page_width_in_pixels,
> Index: webkit/glue/webkit_glue.h
> diff --git a/webkit/glue/webkit_glue.h b/webkit/glue/webkit_glue.h
> index 8e95952a42a2f348322ce914a10b05**f9a8717bda..**
> 30f5181bb5bb51a9a418fa878a03d2**ddbb698252 100644
> --- a/webkit/glue/webkit_glue.h
> +++ b/webkit/glue/webkit_glue.h
> @@ -56,12 +56,6 @@ string16 DumpFramesAsText(WebKit::**WebFrame*
> web_frame, bool recursive);
>  // Returns the renderer's description of its tree (its
> externalRepresentation).
>  WEBKIT_GLUE_EXPORT string16 DumpRenderer(WebKit::WebFrame* web_frame);
>
> -// Fill the value of counter in the element specified by the id into
> -// counter_value.  Return false when the specified id doesn't exist.
> -bool CounterValueForElementById(**WebKit::WebFrame* web_frame,
> -                                const std::string& id,
> -                                string16* counter_value);
> -
>  // Returns the number of page where the specified element will be put.
>  int PageNumberForElementById(**WebKit::WebFrame* web_frame,
>                              const std::string& id,
>
>
>

[commit-bot: I haz the power, 2012-06-12 06:02:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/10546100/1

[commit-bot: I haz the power, 2012-06-12 08:46:13]

Change committed as 141631