Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Unified Diff: media/filters/source_buffer_stream.cc

Issue 10546075: Coverity: Fix pass by value error in source_buffer_stream::DeleteAfter() function. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/source_buffer_stream.cc
diff --git a/media/filters/source_buffer_stream.cc b/media/filters/source_buffer_stream.cc
index 7000bdab1ef579742ba194ee11ec5dd255cdd510..eebecb74ce4de1f0278a8a9e0687d0748c508a28 100644
--- a/media/filters/source_buffer_stream.cc
+++ b/media/filters/source_buffer_stream.cc
@@ -112,7 +112,7 @@ class SourceBufferRange {
private:
// Helper method to delete buffers in |buffers_| starting from
// |starting_point|, an iterator in |buffers_|.
- void DeleteAfter(BufferQueue::iterator starting_point,
+ void DeleteAfter(const BufferQueue::iterator& starting_point,
BufferQueue* deleted_buffers,
BufferQueue::iterator* next_buffer);
@@ -608,7 +608,7 @@ void SourceBufferRange::DeleteAfter(
}
void SourceBufferRange::DeleteAfter(
- BufferQueue::iterator starting_point,
+ const BufferQueue::iterator& starting_point,
BufferQueue* removed_buffers,
BufferQueue::iterator* next_buffer) {
// Return if we're not deleting anything.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698