Coverity: Fix pass by value error in source_buffer_stream::DeleteAfter() function.

media/filters/source_buffer_stream.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/filters/source_buffer_stream.h"
 
 #include <algorithm>
 #include <map>
 
 #include "base/logging.h"
@@ skipping 94 matching lines @@
   // buffered timespan of |range|.
   bool CompletelyOverlaps(const SourceBufferRange& range) const;
 
   // Returns true if the end of this range contains buffers that overlaps with
   // the beginning of |range|.
   bool EndOverlaps(const SourceBufferRange& range) const;
 
  private:
   // Helper method to delete buffers in |buffers_| starting from
   // |starting_point|, an iterator in |buffers_|.
-  void DeleteAfter(BufferQueue::iterator starting_point,
+  void DeleteAfter(const BufferQueue::iterator& starting_point,
                    BufferQueue* deleted_buffers,
                    BufferQueue::iterator* next_buffer);
 
   // Returns the start timestamp of the range.
   base::TimeDelta GetStartTimestamp() const;
 
   // An ordered list of buffers in this range.
   BufferQueue buffers_;
 
   // Maps keyframe timestamps to its index position in |buffers_|.
@@ skipping 475 matching lines @@
     BufferQueue::iterator* next_buffer) {
   // Find the place in |buffers_| where we will begin deleting data.
   BufferQueue::iterator starting_point =
       std::lower_bound(buffers_.begin(), buffers_.end(),
                        buffer,
                        BufferComparator);
   DeleteAfter(starting_point, removed_buffers, next_buffer);
 }
 
 void SourceBufferRange::DeleteAfter(
-    BufferQueue::iterator starting_point,
+    const BufferQueue::iterator& starting_point,
     BufferQueue* removed_buffers,
     BufferQueue::iterator* next_buffer) {
   // Return if we're not deleting anything.
   if (starting_point == buffers_.end())
     return;
 
   // Find the first keyframe after |starting_point|.
   KeyframeMap::iterator starting_point_keyframe =
       keyframe_map_.lower_bound((*starting_point)->GetTimestamp());
 
@@ skipping 115 matching lines @@
   DCHECK(!buffers_.empty());
   return buffers_.front()->GetTimestamp();
 }
 
 base::TimeDelta SourceBufferRange::GetEndTimestamp() const {
   DCHECK(!buffers_.empty());
   return buffers_.back()->GetEndTimestamp();
 }
 
 }  // namespace media