Use different help URLs for menus, accelerators, and WebUI.

Use different help URLs for menus, accelerators, and WebUI.

This adds a "ctx" parameter to help center URLs.  Its value
varies dependending on the manner in which help was
requested.

BUG=128611
TEST=manual: opened help using various methods in Linux and Chrome OS builds and checked that correct URLs were opened (the about page button doesn't work for me, but it's also broken when I do a build using clean source)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141609

[Daniel Erat, 2012-06-08 16:28:52]

https://chromiumcodereview.appspot.com/10546072/diff/2001/chrome/browser/ui/v...
File chrome/browser/ui/views/frame/browser_view.cc (right):

https://chromiumcodereview.appspot.com/10546072/diff/2001/chrome/browser/ui/v...
chrome/browser/ui/views/frame/browser_view.cc:2199: case APPCOMMAND_HELP:       
     return IDC_HELP_PAGE_VIA_KEYBOARD;
It's unclear to me from http://technet.microsoft.com/en-us/query/ms646275
whether this can be invoked via non-keyboard means in Chrome.

https://chromiumcodereview.appspot.com/10546072/diff/2001/chrome/test/functio...
File chrome/test/functional/shortcuts.py (right):

https://chromiumcodereview.appspot.com/10546072/diff/2001/chrome/test/functio...
chrome/test/functional/shortcuts.py:158:
self.ApplyAccelerator(pyauto.IDC_HELP_PAGE_VIA_KEYBOARD)
Nirnimesh, I couldn't find any references to these constants within pyauto.  Are
they automatically generated?

[sky, 2012-06-08 17:05:20]

https://chromiumcodereview.appspot.com/10546072/diff/2001/chrome/app/chrome_c...
File chrome/app/chrome_command_ids.h (right):

https://chromiumcodereview.appspot.com/10546072/diff/2001/chrome/app/chrome_c...
chrome/app/chrome_command_ids.h:163: #define IDC_HELP_PAGE_VIA_MENU         
40119
I think we should maintain all values are increasing, otherwise its easy to
accidentally reuse a value.

[Nirnimesh, 2012-06-08 17:49:40]

https://chromiumcodereview.appspot.com/10546072/diff/2001/chrome/test/functio...
File chrome/test/functional/shortcuts.py (right):

https://chromiumcodereview.appspot.com/10546072/diff/2001/chrome/test/functio...
chrome/test/functional/shortcuts.py:158:
self.ApplyAccelerator(pyauto.IDC_HELP_PAGE_VIA_KEYBOARD)
On 2012/06/08 16:28:52, Daniel Erat wrote:
> Nirnimesh, I couldn't find any references to these constants within pyauto. 
Are
> they automatically generated?

Yes, they're swigged to python automatically (through
chrome/test/pyautolib/pyautolib.i)

[Nirnimesh, 2012-06-08 18:06:20]

chrome/test/functional LGTM

[Daniel Erat, 2012-06-08 18:38:45]

ptal

https://chromiumcodereview.appspot.com/10546072/diff/2001/chrome/app/chrome_c...
File chrome/app/chrome_command_ids.h (right):

https://chromiumcodereview.appspot.com/10546072/diff/2001/chrome/app/chrome_c...
chrome/app/chrome_command_ids.h:163: #define IDC_HELP_PAGE_VIA_MENU         
40119
On 2012/06/08 17:05:20, sky wrote:
> I think we should maintain all values are increasing, otherwise its easy to
> accidentally reuse a value.

Ah, I'll renumber.  I was thrown by some of the existing entries that seemed to
follow this pattern, but I now realize that that's probably done to produce
empty ranges that can be used by code.

[sky, 2012-06-08 20:36:19]

LGTM

[Daniel Erat, 2012-06-08 21:07:11]

Mike, mind taking a look at the Mac part of this?

https://chromiumcodereview.appspot.com/10546072/diff/12001/chrome/browser/app...
File chrome/browser/app_controller_mac.mm (right):

https://chromiumcodereview.appspot.com/10546072/diff/12001/chrome/browser/app...
chrome/browser/app_controller_mac.mm:1032:
menuState_->UpdateCommandEnabled(IDC_HELP_PAGE_VIA_MENU, true);
Should I also be calling this for IDC_HELP_PAGE_VIA_KEYBOARD?  Is there an
additional file that I should be editing for Mac?

[Daniel Erat, 2012-06-11 20:46:15]

Avi, any thoughts on the question in app_controller_mac.mm?

[Avi (use Gerrit), 2012-06-11 20:54:06]

http://codereview.chromium.org/10546072/diff/12001/chrome/browser/app_control...
File chrome/browser/app_controller_mac.mm (right):

http://codereview.chromium.org/10546072/diff/12001/chrome/browser/app_control...
chrome/browser/app_controller_mac.mm:1032:
menuState_->UpdateCommandEnabled(IDC_HELP_PAGE_VIA_MENU, true);
There's no "help" keyboard shortcut on the Mac; I don't know how
IDC_HELP_PAGE_VIA_KEYBOARD would be triggered.

[Daniel Erat, 2012-06-11 21:05:37]

http://codereview.chromium.org/10546072/diff/12001/chrome/browser/app_control...
File chrome/browser/app_controller_mac.mm (right):

http://codereview.chromium.org/10546072/diff/12001/chrome/browser/app_control...
chrome/browser/app_controller_mac.mm:1032:
menuState_->UpdateCommandEnabled(IDC_HELP_PAGE_VIA_MENU, true);
On 2012/06/11 20:54:06, Avi wrote:
> There's no "help" keyboard shortcut on the Mac; I don't know how
> IDC_HELP_PAGE_VIA_KEYBOARD would be triggered.

Thanks, that answers it.  I've removed IDC_HELP_PAGE_VIA_KEYBOARD from
commandDispatch.

[Avi (use Gerrit), 2012-06-11 21:28:59]

lgtm

[commit-bot: I haz the power, 2012-06-12 00:14:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/10546072/3004

[commit-bot: I haz the power, 2012-06-12 00:43:12]

Try job failure for 10546072-3004 (retry) on linux_rel for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-06-12 03:01:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/10546072/3004

[commit-bot: I haz the power, 2012-06-12 03:49:53]

Change committed as 141609