Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4877)

Unified Diff: chrome/browser/app_controller_mac.mm

Issue 10546072: Use different help URLs for menus, accelerators, and WebUI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/chrome_dll.rc ('k') | chrome/browser/chromeos/system/ash_system_tray_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/app_controller_mac.mm
diff --git a/chrome/browser/app_controller_mac.mm b/chrome/browser/app_controller_mac.mm
index 084113688bb2dcd0271b73d44170c9a9a659e676..99b23254e3c82ae4cbdc7d5658787839a6bd896a 100644
--- a/chrome/browser/app_controller_mac.mm
+++ b/chrome/browser/app_controller_mac.mm
@@ -891,11 +891,11 @@ const AEEventClass kAECloudPrintUninstallClass = 'GCPu';
else
Browser::OpenExtensionsWindow(lastProfile);
break;
- case IDC_HELP_PAGE:
+ case IDC_HELP_PAGE_VIA_MENU:
if (Browser* browser = ActivateBrowser(lastProfile))
- browser->ShowHelpTab();
+ browser->ShowHelpTab(Browser::HELP_SOURCE_MENU);
else
- Browser::OpenHelpWindow(lastProfile);
+ Browser::OpenHelpWindow(lastProfile, Browser::HELP_SOURCE_MENU);
break;
case IDC_SHOW_SYNC_SETUP:
if (Browser* browser = ActivateBrowser(lastProfile))
@@ -1024,7 +1024,7 @@ const AEEventClass kAECloudPrintUninstallClass = 'GCPu';
menuState_->UpdateCommandEnabled(IDC_SHOW_HISTORY, true);
menuState_->UpdateCommandEnabled(IDC_SHOW_DOWNLOADS, true);
menuState_->UpdateCommandEnabled(IDC_MANAGE_EXTENSIONS, true);
- menuState_->UpdateCommandEnabled(IDC_HELP_PAGE, true);
+ menuState_->UpdateCommandEnabled(IDC_HELP_PAGE_VIA_MENU, true);
menuState_->UpdateCommandEnabled(IDC_IMPORT_SETTINGS, true);
menuState_->UpdateCommandEnabled(IDC_FEEDBACK, true);
menuState_->UpdateCommandEnabled(IDC_SHOW_SYNC_SETUP, true);
« no previous file with comments | « chrome/app/chrome_dll.rc ('k') | chrome/browser/chromeos/system/ash_system_tray_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698