Move thread checking from autofill_country.cc to browser_process_impl.cc

Move thread checking from autofill_country.cc to browser_process_impl.cc

DCHECK(CalledOnValidThread()) is better than BrowserThread::CurrentlyOn(...)
because it automatically supports unit test without requiring setting up
specific threads.

BUG=132643
TEST=Run Autofill tests in debug build


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142048

[Ilya Sherman, 2012-06-13 23:13:47]

LGTM.  Thanks for the fix! :)

[Xianzhu, 2012-06-13 23:26:35]

On 2012/06/13 23:13:47, Ilya Sherman wrote:
> LGTM.  Thanks for the fix! :)

Thanks for review.

I'm running the tests locally and on try bots. Maybe I will update some tests
(removing some FAILS_ prefix etc.) in this CL.

BTW, I worked on this because we run all tests with DCHECK enabled on Android.

[Ilya Sherman, 2012-06-13 23:40:01]

On 2012/06/13 23:26:35, Xianzhu wrote:
> On 2012/06/13 23:13:47, Ilya Sherman wrote:
> > LGTM.  Thanks for the fix! :)
> 
> Thanks for review.
> 
> I'm running the tests locally and on try bots. Maybe I will update some tests
> (removing some FAILS_ prefix etc.) in this CL.
> 
> BTW, I worked on this because we run all tests with DCHECK enabled on Android.

Yes, all tests run with DCHECK enabled on (many of) the Chromium bots in
general.  These tests only fail when running in isolation; I added a hack to
cache the value that prevents this from coming up when run as part of the full
test suite.

[Xianzhu, 2012-06-13 23:48:32]

On 2012/06/13 23:40:01, Ilya Sherman wrote:
> Yes, all tests run with DCHECK enabled on (many of) the Chromium bots in
> general.  These tests only fail when running in isolation; I added a hack to
> cache the value that prevents this from coming up when run as part of the full
> test suite.

These tests fail on Android in batch run so we noticed them.

Uploaded Patch Set 2 which removes the code about thread in address_unittest.cc
which is no longer needed.

@sky, could you also review this patch. It needs an approval of chrome/browser
dir.

[sky, 2012-06-13 23:50:49]

LGTM

[commit-bot: I haz the power, 2012-06-13 23:52:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/10545169/7001

[commit-bot: I haz the power, 2012-06-14 00:58:21]

Change committed as 142048