Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: chrome/browser/autofill/address_unittest.cc

Issue 10545169: Move thread checking from autofill_country.cc to browser_process_impl.cc (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove code about thread in address_unittest.cc which is no longer needed Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/autofill/autofill_country.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/message_loop.h" 7 #include "base/message_loop.h"
8 #include "base/string16.h" 8 #include "base/string16.h"
9 #include "base/utf_string_conversions.h" 9 #include "base/utf_string_conversions.h"
10 #include "chrome/browser/autofill/address.h" 10 #include "chrome/browser/autofill/address.h"
11 #include "chrome/browser/autofill/autofill_type.h" 11 #include "chrome/browser/autofill/autofill_type.h"
12 #include "content/public/test/test_browser_thread.h" 12 #include "content/public/test/test_browser_thread.h"
13 #include "testing/gtest/include/gtest/gtest.h" 13 #include "testing/gtest/include/gtest/gtest.h"
14 14
15 using content::BrowserThread; 15 using content::BrowserThread;
16 16
17 class AddressTest : public testing::Test {
18 public:
19 // In order to access the application locale -- which the tested functions do
20 // internally -- this test must run on the UI thread.
21 AddressTest() : ui_thread_(BrowserThread::UI, &message_loop_) {}
22
23 private:
24 MessageLoopForUI message_loop_;
25 content::TestBrowserThread ui_thread_;
26
27 DISALLOW_COPY_AND_ASSIGN(AddressTest);
28 };
29
30 // Test that the getters and setters for country code are working. 17 // Test that the getters and setters for country code are working.
31 TEST_F(AddressTest, CountryCode) { 18 TEST(AddressTest, CountryCode) {
32 Address address; 19 Address address;
33 EXPECT_EQ(std::string(), address.country_code()); 20 EXPECT_EQ(std::string(), address.country_code());
34 21
35 address.set_country_code("US"); 22 address.set_country_code("US");
36 EXPECT_EQ("US", address.country_code()); 23 EXPECT_EQ("US", address.country_code());
37 24
38 address.set_country_code("CA"); 25 address.set_country_code("CA");
39 EXPECT_EQ("CA", address.country_code()); 26 EXPECT_EQ("CA", address.country_code());
40 } 27 }
41 28
42 // Test that country codes are properly decoded as country names. 29 // Test that country codes are properly decoded as country names.
43 TEST_F(AddressTest, GetCountry) { 30 TEST(AddressTest, GetCountry) {
44 Address address; 31 Address address;
45 EXPECT_EQ(std::string(), address.country_code()); 32 EXPECT_EQ(std::string(), address.country_code());
46 33
47 // Make sure that nothing breaks when the country code is missing. 34 // Make sure that nothing breaks when the country code is missing.
48 string16 country = address.GetInfo(ADDRESS_HOME_COUNTRY); 35 string16 country = address.GetInfo(ADDRESS_HOME_COUNTRY);
49 EXPECT_EQ(string16(), country); 36 EXPECT_EQ(string16(), country);
50 37
51 address.set_country_code("US"); 38 address.set_country_code("US");
52 country = address.GetInfo(ADDRESS_HOME_COUNTRY); 39 country = address.GetInfo(ADDRESS_HOME_COUNTRY);
53 EXPECT_EQ(ASCIIToUTF16("United States"), country); 40 EXPECT_EQ(ASCIIToUTF16("United States"), country);
54 41
55 address.set_country_code("CA"); 42 address.set_country_code("CA");
56 country = address.GetInfo(ADDRESS_HOME_COUNTRY); 43 country = address.GetInfo(ADDRESS_HOME_COUNTRY);
57 EXPECT_EQ(ASCIIToUTF16("Canada"), country); 44 EXPECT_EQ(ASCIIToUTF16("Canada"), country);
58 } 45 }
59 46
60 // Test that we properly detect country codes appropriate for each country. 47 // Test that we properly detect country codes appropriate for each country.
61 TEST_F(AddressTest, SetCountry) { 48 TEST(AddressTest, SetCountry) {
62 Address address; 49 Address address;
63 EXPECT_EQ(std::string(), address.country_code()); 50 EXPECT_EQ(std::string(), address.country_code());
64 51
65 // Test basic conversion. 52 // Test basic conversion.
66 address.SetInfo(ADDRESS_HOME_COUNTRY, ASCIIToUTF16("United States")); 53 address.SetInfo(ADDRESS_HOME_COUNTRY, ASCIIToUTF16("United States"));
67 string16 country = address.GetInfo(ADDRESS_HOME_COUNTRY); 54 string16 country = address.GetInfo(ADDRESS_HOME_COUNTRY);
68 EXPECT_EQ("US", address.country_code()); 55 EXPECT_EQ("US", address.country_code());
69 EXPECT_EQ(ASCIIToUTF16("United States"), country); 56 EXPECT_EQ(ASCIIToUTF16("United States"), country);
70 57
71 // Test basic synonym detection. 58 // Test basic synonym detection.
(...skipping 15 matching lines...) Expand all
87 EXPECT_EQ(ASCIIToUTF16("Japan"), country); 74 EXPECT_EQ(ASCIIToUTF16("Japan"), country);
88 75
89 // Test that we ignore unknown countries. 76 // Test that we ignore unknown countries.
90 address.SetInfo(ADDRESS_HOME_COUNTRY, ASCIIToUTF16("Unknown")); 77 address.SetInfo(ADDRESS_HOME_COUNTRY, ASCIIToUTF16("Unknown"));
91 country = address.GetInfo(ADDRESS_HOME_COUNTRY); 78 country = address.GetInfo(ADDRESS_HOME_COUNTRY);
92 EXPECT_EQ(std::string(), address.country_code()); 79 EXPECT_EQ(std::string(), address.country_code());
93 EXPECT_EQ(string16(), country); 80 EXPECT_EQ(string16(), country);
94 } 81 }
95 82
96 // Test that we properly match typed values to stored country data. 83 // Test that we properly match typed values to stored country data.
97 TEST_F(AddressTest, IsCountry) { 84 TEST(AddressTest, IsCountry) {
98 Address address; 85 Address address;
99 address.set_country_code("US"); 86 address.set_country_code("US");
100 87
101 const char* const kValidMatches[] = { 88 const char* const kValidMatches[] = {
102 "United States", 89 "United States",
103 "USA", 90 "USA",
104 "US", 91 "US",
105 "United states", 92 "United states",
106 "us" 93 "us"
107 }; 94 };
(...skipping 15 matching lines...) Expand all
123 EXPECT_EQ(0U, matching_types.size()); 110 EXPECT_EQ(0U, matching_types.size());
124 } 111 }
125 112
126 // Make sure that garbage values don't match when the country code is empty. 113 // Make sure that garbage values don't match when the country code is empty.
127 address.set_country_code(""); 114 address.set_country_code("");
128 EXPECT_EQ(std::string(), address.country_code()); 115 EXPECT_EQ(std::string(), address.country_code());
129 FieldTypeSet matching_types; 116 FieldTypeSet matching_types;
130 address.GetMatchingTypes(ASCIIToUTF16("Garbage"), &matching_types); 117 address.GetMatchingTypes(ASCIIToUTF16("Garbage"), &matching_types);
131 EXPECT_EQ(0U, matching_types.size()); 118 EXPECT_EQ(0U, matching_types.size());
132 } 119 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/autofill/autofill_country.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698