Issue 10545065: [net/dns] Don't use memset to initialize a struct with string16 members.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10545065: [net/dns] Don't use memset to initialize a struct with string16 members. (Closed)

Created:
8 years, 6 months ago by szym

Modified:
8 years, 6 months ago

Reviewers:
cbentzel, mmenke

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[net/dns] Don't use memset to initialize a struct with string16 members. Forcing string16 to 0 leads to iterator compatiblity check crash in MSVS2010 Debug builds. This bug was diagnosed by tom.cassiotis@gmail.com BUG=131589 TEST=Start MSVS2010 Debug build of chrome.exe Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141213

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	net/dns/dns_config_service_win.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

jaysoffian

Confirmed this fixes the issue I was having in https://chromiumcodereview.appspot.com/10544054/

8 years, 6 months ago (2012-06-07 23:58:08 UTC) #2

szym

8 years, 6 months ago (2012-06-08 15:44:38 UTC) #5

On 2012/06/08 15:43:34, Matt Menke wrote:
> He's taking today off, I believe.
> 
> LGTM

Thanks!