net/dns/dns_config_service_win.cc - Issue 10545065: [net/dns] Don't use memset to initialize a struct with string16 members.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/dns_config_service_win.cc

Issue 10545065: [net/dns] Don't use memset to initialize a struct with string16 members. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/dns/dns_config_service_win.cc

diff --git a/net/dns/dns_config_service_win.cc b/net/dns/dns_config_service_win.cc

index c64f65142953f0db124604f2e0c3378028086973..af609f040cb06cd737e5104cf760e0aea631c7ca 100644

--- a/net/dns/dns_config_service_win.cc

+++ b/net/dns/dns_config_service_win.cc

@@ -329,8 +329,7 @@ class DnsConfigServiceWin::ConfigReader : public SerialWorker {

// Should be called on WorkerPool.

success_ = false;

- DnsSystemSettings settings;

- memset(&settings, 0, sizeof(settings));

+ DnsSystemSettings settings = {};

settings.addresses = ReadIpHelper(GAA_FLAG_SKIP_ANYCAST |

GAA_FLAG_SKIP_UNICAST |

GAA_FLAG_SKIP_MULTICAST |

« no previous file with comments | « no previous file | no next file » | no next file with comments »