Issue 10545045: Make ScopedGetDC() CHECK fail if GetDC(NULL) returns NULL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10545045: Make ScopedGetDC() CHECK fail if GetDC(NULL) returns NULL. (Closed)

Created:
8 years, 6 months ago by Peter Kasting

Modified:
8 years, 6 months ago

Reviewers:
cpu_(ooo_6.6-7.5), willchan no longer on Chromium, sky

CC:
chromium-reviews, erikwright (departed), James Su, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Make ScopedGetDC() CHECK fail if GetDC(NULL) returns NULL. Use scoping objects more in the omnibox code. BUG=110105 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141087

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -10 lines)			Patch
	M	base/win/scoped_hdc.h	View		1 chunk	+9 lines, -2 lines	0 comments	Download
	M	chrome/browser/ui/views/omnibox/omnibox_view_win.cc	View		3 chunks	+7 lines, -8 lines	0 comments	Download

Total messages: 4 (0 generated)

Peter Kasting

cpu: review willchan: base/ OWNERS sky: chrome/browser/ui/ OWNERS

8 years, 6 months ago (2012-06-07 00:47:57 UTC) #1

lgtm