Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 10545045: Make ScopedGetDC() CHECK fail if GetDC(NULL) returns NULL. (Closed)

Created:
8 years, 6 months ago by Peter Kasting
Modified:
8 years, 6 months ago
CC:
chromium-reviews, erikwright (departed), James Su, brettw-cc_chromium.org
Visibility:
Public.

Description

Make ScopedGetDC() CHECK fail if GetDC(NULL) returns NULL. Use scoping objects more in the omnibox code. BUG=110105 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141087

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M base/win/scoped_hdc.h View 1 chunk +9 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_win.cc View 3 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Peter Kasting
cpu: review willchan: base/ OWNERS sky: chrome/browser/ui/ OWNERS
8 years, 6 months ago (2012-06-07 00:47:57 UTC) #1
sky
LGTM
8 years, 6 months ago (2012-06-07 03:49:35 UTC) #2
willchan no longer on Chromium
lgtm
8 years, 6 months ago (2012-06-07 05:40:48 UTC) #3
cpu_(ooo_6.6-7.5)
8 years, 6 months ago (2012-06-07 21:16:29 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698