Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Side by Side Diff: base/win/scoped_hdc.h

Issue 10545045: Make ScopedGetDC() CHECK fail if GetDC(NULL) returns NULL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/ui/views/omnibox/omnibox_view_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_WIN_SCOPED_HDC_H_ 5 #ifndef BASE_WIN_SCOPED_HDC_H_
6 #define BASE_WIN_SCOPED_HDC_H_ 6 #define BASE_WIN_SCOPED_HDC_H_
7 #pragma once 7 #pragma once
8 8
9 #include <windows.h> 9 #include <windows.h>
10 10
11 #include "base/basictypes.h" 11 #include "base/basictypes.h"
12 #include "base/logging.h" 12 #include "base/logging.h"
13 13
14 namespace base { 14 namespace base {
15 namespace win { 15 namespace win {
16 16
17 // Like ScopedHandle but for HDC. Only use this on HDCs returned from 17 // Like ScopedHandle but for HDC. Only use this on HDCs returned from
18 // GetDC. 18 // GetDC.
19 class ScopedGetDC { 19 class ScopedGetDC {
20 public: 20 public:
21 explicit ScopedGetDC(HWND hwnd) 21 explicit ScopedGetDC(HWND hwnd)
22 : hwnd_(hwnd), 22 : hwnd_(hwnd),
23 hdc_(GetDC(hwnd)) { 23 hdc_(GetDC(hwnd)) {
24 DCHECK(!hwnd_ || IsWindow(hwnd_)); 24 if (hwnd_) {
25 DCHECK(hdc_); 25 DCHECK(IsWindow(hwnd_));
26 DCHECK(hdc_);
27 } else {
28 // If GetDC(NULL) returns NULL, something really bad has happened, like
29 // GDI handle exhaustion. In this case Chrome is going to behave badly no
30 // matter what, so we may as well just force a crash now.
31 CHECK(hdc_);
32 }
26 } 33 }
27 34
28 ~ScopedGetDC() { 35 ~ScopedGetDC() {
29 if (hdc_) 36 if (hdc_)
30 ReleaseDC(hwnd_, hdc_); 37 ReleaseDC(hwnd_, hdc_);
31 } 38 }
32 39
33 operator HDC() { return hdc_; } 40 operator HDC() { return hdc_; }
34 41
35 private: 42 private:
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 80
74 HDC hdc_; 81 HDC hdc_;
75 82
76 DISALLOW_COPY_AND_ASSIGN(ScopedCreateDC); 83 DISALLOW_COPY_AND_ASSIGN(ScopedCreateDC);
77 }; 84 };
78 85
79 } // namespace win 86 } // namespace win
80 } // namespace base 87 } // namespace base
81 88
82 #endif // BASE_WIN_SCOPED_HDC_H_ 89 #endif // BASE_WIN_SCOPED_HDC_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/views/omnibox/omnibox_view_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698