Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 10544113: Revert 141690 - Modify old Panel test files and include them in .gyp. (Closed)

Created:
8 years, 6 months ago by sail
Modified:
8 years, 6 months ago
Reviewers:
jennb
CC:
chromium-reviews, jennb, jianli, Dmitry Titov, dcheng
Visibility:
Public.

Description

Revert 141690 - Modify old Panel test files and include them in .gyp. here's the build log: http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Tests%20%282%29&number=3405 BUG=None TEST=Old tests set up to be runnable. Review URL: https://chromiumcodereview.appspot.com/10544105 TBR=jennb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141692

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -168 lines) Patch
M chrome/browser/ui/panels/base_panel_browser_test.cc View 2 chunks +17 lines, -7 lines 0 comments Download
M chrome/browser/ui/panels/native_panel.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/old_base_panel_browser_test.h View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/panels/old_base_panel_browser_test.cc View 18 chunks +43 lines, -34 lines 0 comments Download
M chrome/browser/ui/panels/old_detached_panel_browsertest.cc View 5 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/ui/panels/old_docked_panel_browsertest.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/panels/old_panel_and_desktop_notification_browsertest.cc View 12 chunks +14 lines, -16 lines 0 comments Download
M chrome/browser/ui/panels/old_panel_browsertest.cc View 39 chunks +41 lines, -43 lines 0 comments Download
M chrome/browser/ui/panels/old_panel_drag_browsertest.cc View 18 chunks +21 lines, -21 lines 0 comments Download
M chrome/browser/ui/panels/old_panel_resize_browsertest.cc View 7 chunks +11 lines, -13 lines 0 comments Download
M chrome/browser/ui/panels/panel.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_browser_window.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_mouse_watcher.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sail
8 years, 6 months ago (2012-06-12 18:43:15 UTC) #1
jennb
8 years, 6 months ago (2012-06-12 19:02:00 UTC) #2
LGTM sorry.

Powered by Google App Engine
This is Rietveld 408576698