Modify old Panel test files and include them in .gyp.

Modify old Panel test files and include them in .gyp.

BUG=None
TEST=Old tests set up to be runnable.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141690 (reverted in 141692)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141694

[jennb, 2012-06-12 00:24:30]

Created old panel tests as a baseline that the refactoring doesn't break
existing tests. Files intended to test refactored panels are not changed in this
patch. Those files will be changed in the same patch that adds functionality
that those files will verify.

[Dmitry Titov, 2012-06-12 01:16:41]

On 2012/06/12 00:24:30, jennb wrote:
> Created old panel tests as a baseline that the refactoring doesn't break
> existing tests. Files intended to test refactored panels are not changed in
this
> patch. Those files will be changed in the same patch that adds functionality
> that those files will verify.

Do you want to add new files (panel_cocoa_unittest.cc and another one, from
http://codereview.chromium.org/10545126)  to gypi file as well, so we have a
full set of tests running?

Also, the compile on linux fails because there is "friend class
BasePanelBrowserTest;" in browser_list.h, and a stern comment preventing form
adding more 'friends' :-) Might disable this (part of the) test perhaps.

[Dmitry Titov, 2012-06-12 01:17:01]

otherwise LGTM

[jennb, 2012-06-12 06:47:40]

On Mon, Jun 11, 2012 at 6:16 PM, <dimich@chromium.org> wrote:

> On 2012/06/12 00:24:30, jennb wrote:
>
>> Created old panel tests as a baseline that the refactoring doesn't break
>> existing tests. Files intended to test refactored panels are not changed
>> in
>>
> this
>
>> patch. Those files will be changed in the same patch that adds
>> functionality
>> that those files will verify.
>>
>
> Do you want to add new files (panel_cocoa_unittest.cc and another one, from
>
http://codereview.chromium.**org/10545126<http://codereview.chromium.org/1054...)
>  to gypi file as well, so we have a
> full set of tests running?
>

I intentionally left them out for now so I don't have to edit them at all
until I'm ready to update them to work with refactored panels.


>
> Also, the compile on linux fails because there is "friend class
> BasePanelBrowserTest;" in browser_list.h, and a stern comment preventing
> form
> adding more 'friends' :-) Might disable this (part of the) test perhaps.
>

Hmmm... the linux tests use BrowserList::GetLastActive() to restore the
previous active window when creating an inactive panel because there's no
way to truly create an inactive panel. Disabling means disabling all linux
tests that create an inactive panel. Might have to find a workaround.



>
>
http://codereview.chromium.**org/10544105/<http://codereview.chromium.org/105...
>

[jennb, 2012-06-12 17:55:45]

Changed [Old]BasePanelBrowserTest to reactivate main tabbed browser to
"deactivate" the newly created panel to avoid BrowserList::GetLastActive().
The tests that create inactive panels don't assert that the previously
active window remains the active window (thank goodness).

Will commit if try bots like this change.

On Mon, Jun 11, 2012 at 11:47 PM, Jenn Braithwaite (胡慧鋒) <jennb@chromium.org
> wrote:

>
>
> On Mon, Jun 11, 2012 at 6:16 PM, <dimich@chromium.org> wrote:
>
>> On 2012/06/12 00:24:30, jennb wrote:
>>
>>> Created old panel tests as a baseline that the refactoring doesn't break
>>> existing tests. Files intended to test refactored panels are not changed
>>> in
>>>
>> this
>>
>>> patch. Those files will be changed in the same patch that adds
>>> functionality
>>> that those files will verify.
>>>
>>
>> Do you want to add new files (panel_cocoa_unittest.cc and another one,
>> from
>>
http://codereview.chromium.**org/10545126<http://codereview.chromium.org/1054...)
>>  to gypi file as well, so we have a
>> full set of tests running?
>>
>
> I intentionally left them out for now so I don't have to edit them at all
> until I'm ready to update them to work with refactored panels.
>
>
>>
>> Also, the compile on linux fails because there is "friend class
>> BasePanelBrowserTest;" in browser_list.h, and a stern comment preventing
>> form
>> adding more 'friends' :-) Might disable this (part of the) test perhaps.
>>
>
> Hmmm... the linux tests use BrowserList::GetLastActive() to restore the
> previous active window when creating an inactive panel because there's no
> way to truly create an inactive panel. Disabling means disabling all linux
> tests that create an inactive panel. Might have to find a workaround.
>
>
>
>>
>>
http://codereview.chromium.**org/10544105/<http://codereview.chromium.org/105...
>>
>
>

[Dmitry Titov, 2012-06-12 18:06:57]

sg

[sail, 2012-06-12 18:40:17]

It looks like this is failing on the waterfall:
http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20C...

revert?

[jennb, 2012-06-12 18:53:29]

Oops, forgot to exclude new panel tests files from chromeos. Fixing.

On Tue, Jun 12, 2012 at 11:40 AM, <sail@chromium.org> wrote:

> It looks like this is failing on the waterfall:
> http://build.chromium.org/p/**chromium.chromiumos/**
>
buildstatus?builder=Linux%**20ChromiumOS%20Tests%20%282%**29&number=3405<http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Tests%20%282%29&number=3405>
>
> revert?
>
>
https://chromiumcodereview.**appspot.com/10544105/<https://chromiumcodereview...
>