Move usb_keycode_map.h into ui/base/keycodes.

Move usb_keycode_map.h into ui/base/keycodes.

This file contains the mapping table to convert to/from USB scan codes and
native Mac, Win and Linux key codes.

Currently, 2 exact copies of this file exist:
 * webkit/plugins/ppapi
 * remoting/host
This cl combines these files into one super-powerful USB key mapping table!

BUG=118432
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141930

[tfarina, 2012-06-12 20:27:50]

http://codereview.chromium.org/10544106/diff/10001/ui/base/keycodes/OWNERS
File ui/base/keycodes/OWNERS (right):

http://codereview.chromium.org/10544106/diff/10001/ui/base/keycodes/OWNERS#ne...
ui/base/keycodes/OWNERS:1: garykac@chromium.org
is this really necessary? what about the people who wrote  keyboard_code*? I
think ui/OWNERS is enough for this code.

[Wez, 2012-06-12 20:33:06]

http://codereview.chromium.org/10544106/diff/10001/ui/base/keycodes/OWNERS
File ui/base/keycodes/OWNERS (right):

http://codereview.chromium.org/10544106/diff/10001/ui/base/keycodes/OWNERS#ne...
ui/base/keycodes/OWNERS:1: garykac@chromium.org
On 2012/06/12 20:27:51, tfarina wrote:
> is this really necessary? what about the people who wrote  keyboard_code*? I
> think ui/OWNERS is enough for this code.

Yes, there's already a bunch of code in ui/base/keycodes (mainly for testing, I
think?), which I don't think Gary and I should "own". ;)

http://codereview.chromium.org/10544106/diff/10001/ui/base/keycodes/usb_keyco...
File ui/base/keycodes/usb_keycode_map.h (right):

http://codereview.chromium.org/10544106/diff/10001/ui/base/keycodes/usb_keyco...
ui/base/keycodes/usb_keycode_map.h:17: //  On Windows: Windows OEM scancode
TODO(garykac)
Are these two TODOs still valid? If so, what is still to-do?

[garykac, 2012-06-12 20:41:37]

http://codereview.chromium.org/10544106/diff/10001/ui/base/keycodes/OWNERS
File ui/base/keycodes/OWNERS (right):

http://codereview.chromium.org/10544106/diff/10001/ui/base/keycodes/OWNERS#ne...
ui/base/keycodes/OWNERS:1: garykac@chromium.org
On 2012/06/12 20:27:51, tfarina wrote:
> is this really necessary? what about the people who wrote  keyboard_code*? I
> think ui/OWNERS is enough for this code.

We will need to update the table periodically as we add support for new key
mappings. We shouldn't be OWNERS at a higher level, and don't need to bother
ui/OWNERS for simple changes.

There is no "set noparent" here, so the situation for the people who wrote
keyboard_code* is unchanged. The creator seems to be ben@, who already has
OWNERship.

Would it be better to add ben@ explicitly here with a comment stating that he
should review changes to keyboard_code and gary/wez are for changes to
usb_keycode_map.h ?

[tfarina, 2012-06-12 20:43:37]

On 2012/06/12 20:41:37, garykac wrote:
> Would it be better to add ben@ explicitly here with a comment stating that he
> should review changes to keyboard_code and gary/wez are for changes to
> usb_keycode_map.h ?

I think with just a comment saying you are for usb_keycode_map.h only.  That is
fine.

[garykac, 2012-06-12 20:44:13]

http://codereview.chromium.org/10544106/diff/10001/ui/base/keycodes/usb_keyco...
File ui/base/keycodes/usb_keycode_map.h (right):

http://codereview.chromium.org/10544106/diff/10001/ui/base/keycodes/usb_keyco...
ui/base/keycodes/usb_keycode_map.h:17: //  On Windows: Windows OEM scancode
TODO(garykac)
On 2012/06/12 20:33:06, Wez wrote:
> Are these two TODOs still valid? If so, what is still to-do?

Done.

[garykac, 2012-06-12 20:47:40]

On 2012/06/12 20:43:37, tfarina wrote:
> 
> I think with just a comment saying you are for usb_keycode_map.h only.  That
is
> fine.

Done.

[Wez, 2012-06-12 20:48:29]

lgtm

[Ben Goodger (Google), 2012-06-13 16:08:34]

lgtm

[brettw, 2012-06-13 16:43:07]

lgtm

[commit-bot: I haz the power, 2012-06-13 17:04:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/garykac@chromium.org/10544106/4002

[commit-bot: I haz the power, 2012-06-13 19:21:42]

Change committed as 141930