Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: chrome/browser/ui/panels/old_panel_and_desktop_notification_browsertest.cc

Issue 10544105: Modify old Panel test files and include them in .gyp. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: exclude new panel browser tests files from chromeos Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/old_panel_and_desktop_notification_browsertest.cc
diff --git a/chrome/browser/ui/panels/old_panel_and_desktop_notification_browsertest.cc b/chrome/browser/ui/panels/old_panel_and_desktop_notification_browsertest.cc
index 44128bf04dcbe6f7270ece85cc1c5536646cad14..0bb710a85d79f6dfdc82a8bed3b7829dad75dc27 100644
--- a/chrome/browser/ui/panels/old_panel_and_desktop_notification_browsertest.cc
+++ b/chrome/browser/ui/panels/old_panel_and_desktop_notification_browsertest.cc
@@ -11,7 +11,7 @@
#include "chrome/browser/notifications/notification_ui_manager.h"
#include "chrome/browser/prefs/pref_service.h"
#include "chrome/browser/ui/browser.h"
-#include "chrome/browser/ui/panels/base_panel_browser_test.h"
+#include "chrome/browser/ui/panels/old_base_panel_browser_test.h"
#include "chrome/browser/ui/panels/panel.h"
#include "chrome/browser/ui/panels/panel_manager.h"
#include "chrome/browser/ui/panels/test_panel_mouse_watcher.h"
@@ -24,12 +24,12 @@
// desktop notification code a chance to process the change notifications,
// we call MessageLoopForUI::current()->RunAllPending() after any panel change
// has been made.
-class PanelAndDesktopNotificationTest : public BasePanelBrowserTest {
+class OldPanelAndDesktopNotificationTest : public OldBasePanelBrowserTest {
public:
- PanelAndDesktopNotificationTest() : BasePanelBrowserTest() {
+ OldPanelAndDesktopNotificationTest() : OldBasePanelBrowserTest() {
}
- virtual ~PanelAndDesktopNotificationTest() {
+ virtual ~OldPanelAndDesktopNotificationTest() {
}
virtual void SetUpOnMainThread() OVERRIDE {
@@ -37,7 +37,7 @@ class PanelAndDesktopNotificationTest : public BasePanelBrowserTest {
// does not have the hook up for testing work area.
disable_display_settings_mock();
- BasePanelBrowserTest::SetUpOnMainThread();
+ OldBasePanelBrowserTest::SetUpOnMainThread();
g_browser_process->local_state()->SetInteger(
prefs::kDesktopNotificationPosition, BalloonCollection::LOWER_RIGHT);
@@ -55,7 +55,7 @@ class PanelAndDesktopNotificationTest : public BasePanelBrowserTest {
service_.reset();
ui_manager_.reset();
- BasePanelBrowserTest::CleanUpOnMainThread();
+ OldBasePanelBrowserTest::CleanUpOnMainThread();
}
content::ShowDesktopNotificationHostMsgParams StandardTestNotification() {
@@ -120,7 +120,7 @@ class PanelAndDesktopNotificationTest : public BasePanelBrowserTest {
scoped_ptr<DesktopNotificationService> service_;
};
-IN_PROC_BROWSER_TEST_F(PanelAndDesktopNotificationTest, AddAndClosePanel) {
+IN_PROC_BROWSER_TEST_F(OldPanelAndDesktopNotificationTest, AddAndClosePanel) {
Balloon* balloon = CreateBalloon();
int original_balloon_bottom = GetBalloonBottomPosition(balloon);
@@ -139,7 +139,7 @@ IN_PROC_BROWSER_TEST_F(PanelAndDesktopNotificationTest, AddAndClosePanel) {
EXPECT_EQ(original_balloon_bottom, GetBalloonBottomPosition(balloon));
}
-IN_PROC_BROWSER_TEST_F(PanelAndDesktopNotificationTest,
+IN_PROC_BROWSER_TEST_F(OldPanelAndDesktopNotificationTest,
ExpandAndCollapsePanel) {
// Disable mouse watcher since we don't want mouse movements to affect panel
// testing for title-only state.
@@ -183,7 +183,7 @@ IN_PROC_BROWSER_TEST_F(PanelAndDesktopNotificationTest,
PanelManager::GetInstance()->CloseAll();
}
-IN_PROC_BROWSER_TEST_F(PanelAndDesktopNotificationTest, DragNarrowPanel) {
+IN_PROC_BROWSER_TEST_F(OldPanelAndDesktopNotificationTest, DragNarrowPanel) {
Balloon* balloon = CreateBalloon();
// Let the panel width be smaller than the balloon width.
@@ -207,7 +207,7 @@ IN_PROC_BROWSER_TEST_F(PanelAndDesktopNotificationTest, DragNarrowPanel) {
PanelManager::GetInstance()->CloseAll();
}
-IN_PROC_BROWSER_TEST_F(PanelAndDesktopNotificationTest, DragWidePanel) {
+IN_PROC_BROWSER_TEST_F(OldPanelAndDesktopNotificationTest, DragWidePanel) {
Balloon* balloon = CreateBalloon();
// Let the panel width be greater than the balloon width.
@@ -233,7 +233,8 @@ IN_PROC_BROWSER_TEST_F(PanelAndDesktopNotificationTest, DragWidePanel) {
PanelManager::GetInstance()->CloseAll();
}
-IN_PROC_BROWSER_TEST_F(PanelAndDesktopNotificationTest, DetachAndAttachPanel) {
+IN_PROC_BROWSER_TEST_F(OldPanelAndDesktopNotificationTest,
+ DetachAndAttachPanel) {
PanelManager* panel_manager = PanelManager::GetInstance();
Balloon* balloon = CreateBalloon();
int original_balloon_bottom = GetBalloonBottomPosition(balloon);
@@ -266,7 +267,7 @@ IN_PROC_BROWSER_TEST_F(PanelAndDesktopNotificationTest, DetachAndAttachPanel) {
panel_manager->CloseAll();
}
-IN_PROC_BROWSER_TEST_F(PanelAndDesktopNotificationTest, ResizePanel) {
+IN_PROC_BROWSER_TEST_F(OldPanelAndDesktopNotificationTest, ResizePanel) {
PanelManager* panel_manager = PanelManager::GetInstance();
Balloon* balloon = CreateBalloon();
@@ -302,7 +303,7 @@ IN_PROC_BROWSER_TEST_F(PanelAndDesktopNotificationTest, ResizePanel) {
panel_manager->CloseAll();
}
-IN_PROC_BROWSER_TEST_F(PanelAndDesktopNotificationTest, ResizePanelByMouse) {
+IN_PROC_BROWSER_TEST_F(OldPanelAndDesktopNotificationTest, ResizePanelByMouse) {
Balloon* balloon = CreateBalloon();
// Create a docked panel. Expect that the notification balloon moves up to be
@@ -331,7 +332,8 @@ IN_PROC_BROWSER_TEST_F(PanelAndDesktopNotificationTest, ResizePanelByMouse) {
PanelManager::GetInstance()->CloseAll();
}
-IN_PROC_BROWSER_TEST_F(PanelAndDesktopNotificationTest, InteractWithTwoPanels) {
+IN_PROC_BROWSER_TEST_F(OldPanelAndDesktopNotificationTest,
+ InteractWithTwoPanels) {
Balloon* balloon = CreateBalloon();
int original_balloon_bottom = GetBalloonBottomPosition(balloon);
« no previous file with comments | « chrome/browser/ui/panels/old_docked_panel_browsertest.cc ('k') | chrome/browser/ui/panels/old_panel_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698