Double dollar ($$) parsing in messages.json broken

Double dollar ($$) parsing in messages.json broken

Fixed the above behavior. $$ is now parsed properly.

BUG=127243
TEST=browser_tests --gtest_filter=ExtensionApiTest.I18N


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141280

[Matt Perry, 2012-06-08 19:09:42]

I'm confused... Where is the fix?

https://chromiumcodereview.appspot.com/10544066/diff/1/chrome/test/data/exten...
File chrome/test/data/extensions/api_test/i18n/test.js (right):

https://chromiumcodereview.appspot.com/10544066/diff/1/chrome/test/data/exten...
chrome/test/data/extensions/api_test/i18n/test.js:42: "We should really be
paying Mitchell and Chris more $$$.");
$$$$ becomes $$$? Shouldn't it be $$?

[mitchellwrosen, 2012-06-08 19:15:27]

The fix is that previously, if getMessage() was called with only one argument,
or a second null argument, the message would be returned literally. Now, that
code path falls through to the final return, where ReplaceStringPlaceholders()
is called, which a) replaces all placeholders, and b) replaces all $+ with one
less $.

I thought the $$$$ -> $$$ was a little strange too, but the behavior is
documented in a comment. Should I change it?

[Matt Perry, 2012-06-08 19:22:03]

lgtm

[commit-bot: I haz the power, 2012-06-08 19:26:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mitchellwrosen@chromium.org/10544066/1

[commit-bot: I haz the power, 2012-06-08 20:44:55]

Change committed as 141280