Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1149)

Unified Diff: chrome/test/data/extensions/api_test/i18n/test.js

Issue 10544066: Double dollar ($$) parsing in messages.json broken (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/extensions/api_test/i18n/_locales/en_US/messages.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/api_test/i18n/test.js
diff --git a/chrome/test/data/extensions/api_test/i18n/test.js b/chrome/test/data/extensions/api_test/i18n/test.js
index e2c860cefa6710cba6618749dc742ed31dd1297f..bbe6ea9f194b0f1a42ac636b90b970ac6f4e91f1 100644
--- a/chrome/test/data/extensions/api_test/i18n/test.js
+++ b/chrome/test/data/extensions/api_test/i18n/test.js
@@ -26,12 +26,21 @@ chrome.test.getConfig(function(config) {
chrome.test.assertEq(message, "Simple message");
message = chrome.i18n.getMessage("message_with_placeholders",
- ["Cira", "John"]);
+ ["Cira", "John"]);
chrome.test.assertEq(message, "Cira and John work for Google");
message = chrome.i18n.getMessage("message_with_one_placeholder", "19");
chrome.test.assertEq(message, "Number of errors: 19");
+ message = chrome.i18n.getMessage("message_with_double_dollar_sign");
+ chrome.test.assertEq(message, "I need $500 please.");
+
+ message = chrome.i18n.getMessage(
+ "message_with_double_dollar_sign_and_placeholders",
+ ["Mitchell", "Chris"]);
+ chrome.test.assertEq(message,
+ "We should really be paying Mitchell and Chris more $$$.");
Matt Perry 2012/06/08 19:09:42 $$$$ becomes $$$? Shouldn't it be $$?
+
chrome.test.succeed();
},
function getMessageFromContentScript() {
« no previous file with comments | « chrome/test/data/extensions/api_test/i18n/_locales/en_US/messages.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698