Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3965)

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

Issue 10544059: Change the platform app manifest structure. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc
diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc
index ab7a8525804eadc1f05871a09551f7c2d6a31b31..929512da324e7d0d789da0c86c684ae7482f79a6 100644
--- a/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc
+++ b/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc
@@ -31,13 +31,20 @@ TEST_F(ExtensionManifestTest, PlatformApps) {
"(theme, app, etc.).",
extension->install_warnings()[0]);
- LoadAndExpectError(
- "init_invalid_platform_app_2.json",
- extension_manifest_errors::kBackgroundRequiredForPlatformApps);
-
- LoadAndExpectError(
- "init_invalid_platform_app_3.json",
- extension_manifest_errors::kPlatformAppNeedsManifestVersion2);
+ Testcase testcases[] = {
+ Testcase("init_invalid_platform_app_2.json",
+ errors::kBackgroundRequiredForPlatformApps),
+ Testcase("init_invalid_platform_app_2.json",
+ errors::kBackgroundRequiredForPlatformApps),
+ Testcase("init_invalid_platform_app_3.json",
+ errors::kPlatformAppNeedsManifestVersion2),
+ Testcase("init_invalid_platform_app_4.json",
+ errors::kPlatformAppInvalidBackgroundScripts),
+ Testcase("init_invalid_platform_app_5.json",
+ errors::kPlatformAppInvalidBackgroundPage)
+ };
+ RunTestcases(testcases, arraysize(testcases),
+ EXPECT_TYPE_ERROR);
}
TEST_F(ExtensionManifestTest, CertainApisRequirePlatformApps) {

Powered by Google App Engine
This is Rietveld 408576698