Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8094)

Unified Diff: chrome/common/extensions/manifest_unittest.cc

Issue 10544059: Change the platform app manifest structure. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_unittest.cc
diff --git a/chrome/common/extensions/manifest_unittest.cc b/chrome/common/extensions/manifest_unittest.cc
index a674b4ecfc12524fe450dc01757f59e764c651da..48f079f8c70a5621d3aaa2e8499714c7d3678161 100644
--- a/chrome/common/extensions/manifest_unittest.cc
+++ b/chrome/common/extensions/manifest_unittest.cc
@@ -134,24 +134,18 @@ TEST_F(ManifestTest, ExtensionTypes) {
MutateManifest(
&manifest, keys::kTheme, NULL);
- // Platform app.
- MutateManifest(
- &manifest, keys::kPlatformApp, new DictionaryValue());
- AssertType(manifest.get(), Extension::TYPE_EXTENSION); // must be boolean
- MutateManifest(
- &manifest, keys::kPlatformApp, Value::CreateBooleanValue(false));
- AssertType(manifest.get(), Extension::TYPE_EXTENSION); // must be true
- MutateManifest(
- &manifest, keys::kPlatformApp, Value::CreateBooleanValue(true));
- AssertType(manifest.get(), Extension::TYPE_PLATFORM_APP);
- MutateManifest(
- &manifest, keys::kPlatformApp, NULL);
-
// Packaged app.
MutateManifest(
&manifest, keys::kApp, new DictionaryValue());
AssertType(manifest.get(), Extension::TYPE_PACKAGED_APP);
+ // Platform app.
+ MutateManifest(
+ &manifest, keys::kPlatformAppBackground, new DictionaryValue());
+ AssertType(manifest.get(), Extension::TYPE_PLATFORM_APP);
+ MutateManifest(
+ &manifest, keys::kPlatformAppBackground, NULL);
+
// Hosted app.
MutateManifest(
&manifest, keys::kWebURLs, new ListValue());
@@ -188,12 +182,12 @@ TEST_F(ManifestTest, RestrictedKeys) {
EXPECT_TRUE(manifest->Get(keys::kPageAction, &output));
MutateManifest(
- &manifest, keys::kPlatformApp, Value::CreateBooleanValue(true));
+ &manifest, keys::kPlatformAppBackground, new DictionaryValue());
AssertType(manifest.get(), Extension::TYPE_PLATFORM_APP);
EXPECT_FALSE(manifest->HasKey(keys::kPageAction));
EXPECT_FALSE(manifest->Get(keys::kPageAction, &output));
MutateManifest(
- &manifest, keys::kPlatformApp, NULL);
+ &manifest, keys::kPlatformAppBackground, NULL);
// "commands" is restricted to manifest_version >= 2.
MutateManifest(

Powered by Google App Engine
This is Rietveld 408576698