Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 10544059: Change the platform app manifest structure. (Closed)

Created:
8 years, 6 months ago by Mihai Parparita -not on Chrome
Modified:
8 years, 6 months ago
Reviewers:
miket_OOO
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Change the platform app manifest structure. Instead of an explicit "platform_app": true manifest keys, platform apps are now defined by the presence of the "background" section inside "app" (since platform apps require background pages). The top-level "background" section is not supported for platform apps. R=miket@chromium.org BUG=131394 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141177

Patch Set 1 #

Total comments: 4

Patch Set 2 : Missed new files #

Patch Set 3 : fix calculator #

Patch Set 4 : Update for getDisplayPath, implement restrictions via _manifest_features.json #

Unified diffs Side-by-side diffs Delta from patch set Stats (+324 lines, -210 lines) Patch
M chrome/common/extensions/api/_manifest_features.json View 1 2 3 4 chunks +8 lines, -7 lines 0 comments Download
M chrome/common/extensions/docs/build/directory.py View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/calculator.zip View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/calculator/main.js View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/calculator/manifest.json View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/samples.html View 1 2 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/common/extensions/docs/samples.json View 1 2 4 chunks +6 lines, -7 lines 0 comments Download
M chrome/common/extensions/extension.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension.cc View 1 2 3 4 chunks +40 lines, -19 lines 0 comments Download
M chrome/common/extensions/extension_manifest_constants.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M chrome/common/extensions/extension_manifest_constants.cc View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M chrome/common/extensions/manifest.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/manifest.cc View 2 chunks +13 lines, -12 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifest_test.h View 1 2 3 2 chunks +21 lines, -3 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifest_test.cc View 1 2 3 3 chunks +32 lines, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc View 1 2 3 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc View 1 2 3 1 chunk +29 lines, -14 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_storage_unittest.cc View 1 2 3 3 chunks +3 lines, -18 lines 0 comments Download
M chrome/common/extensions/manifest_unittest.cc View 2 chunks +9 lines, -15 lines 0 comments Download
M chrome/test/data/extensions/allow_silent_upgrade/scopes1_new.json View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/allow_silent_upgrade/scopes1_old.json View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/allow_silent_upgrade/scopes2_new.json View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/allow_silent_upgrade/scopes2_old.json View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/allow_silent_upgrade/scopes3_new.json View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/allow_silent_upgrade/scopes3_old.json View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/dns/api/manifest.json View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/identity/manifest.json View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/serial/api/manifest.json View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/socket/api/manifest.json View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/manifest_tests/init_invalid_platform_app_1.json View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/test/data/extensions/manifest_tests/init_invalid_platform_app_2.json View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/manifest_tests/init_invalid_platform_app_3.json View 1 chunk +4 lines, -3 lines 0 comments Download
A + chrome/test/data/extensions/manifest_tests/init_invalid_platform_app_4.json View 1 1 chunk +6 lines, -6 lines 0 comments Download
A chrome/test/data/extensions/manifest_tests/init_invalid_platform_app_5.json View 1 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/manifest_tests/init_valid_platform_app.json View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/manifest_tests/sandboxed_pages_invalid_5.json View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/context_menu/manifest.json View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/get_display_path/manifest.json View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/iframes/manifest.json View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/isolation/manifest.json View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/launch/manifest.json View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/launch_file/manifest.json View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/launch_invalid/manifest.json View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/launch_no_intent/manifest.json View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/launch_nothing/manifest.json View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/launch_wrong_intent/manifest.json View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/launch_wrong_type/manifest.json View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/minimal/manifest.json View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/navigation/manifest.json View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/restrictions/manifest.json View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/storage/manifest.json View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/windows_api/manifest.json View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Mihai Parparita -not on Chrome
8 years, 6 months ago (2012-06-07 21:11:52 UTC) #1
miket_OOO
LGTM. See comments. Please send out PSA and update Hello World page before this lands. ...
8 years, 6 months ago (2012-06-07 21:34:19 UTC) #2
Mihai Parparita -not on Chrome
https://chromiumcodereview.appspot.com/10544059/diff/1/chrome/common/extensions/extension_manifest_constants.cc File chrome/common/extensions/extension_manifest_constants.cc (right): https://chromiumcodereview.appspot.com/10544059/diff/1/chrome/common/extensions/extension_manifest_constants.cc#newcode477 chrome/common/extensions/extension_manifest_constants.cc:477: "Loading platform_app extension type is turned off by default. ...
8 years, 6 months ago (2012-06-07 21:40:01 UTC) #3
miket_OOO
OK!
8 years, 6 months ago (2012-06-07 21:46:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihaip@chromium.org/10544059/3002
8 years, 6 months ago (2012-06-07 21:59:33 UTC) #5
commit-bot: I haz the power
Presubmit check for 10544059-3002 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 6 months ago (2012-06-07 22:00:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihaip@chromium.org/10544059/7042
8 years, 6 months ago (2012-06-08 00:14:45 UTC) #7
commit-bot: I haz the power
Try job failure for 10544059-7042 (retry) on linux_rel for step "browser_tests". It's a second try, ...
8 years, 6 months ago (2012-06-08 01:09:01 UTC) #8
Mihai Parparita -not on Chrome
http://crrev.com/141119 added another manifest that needs updating. Will fix and retry. Mihai On Thu, Jun ...
8 years, 6 months ago (2012-06-08 01:10:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihaip@chromium.org/10544059/7050
8 years, 6 months ago (2012-06-08 04:44:16 UTC) #10
commit-bot: I haz the power
8 years, 6 months ago (2012-06-08 05:45:06 UTC) #11
Change committed as 141177

Powered by Google App Engine
This is Rietveld 408576698