chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc - Issue 10544059: Change the platform app manifest structure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc

Issue 10544059: Change the platform app manifest structure. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update for getDisplayPath, implement restrictions via _manifest_features.json Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifest_test.cc ('k') | chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc

index 7bd211daa7ba66b622cd1b60cc130c15b0ec8eef..83bbbc9bd03ce2fc57ac5343fe618b6dbb930535 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc

@@ -68,11 +68,9 @@ TEST_F(ExtensionManifestTest, BackgroundPage) {

manifest->SetInteger(keys::kManifestVersion, 2);

Feature* feature = SimpleFeatureProvider::GetManifestFeatures()->

GetFeature("background_page");

- extension = LoadAndExpectSuccess(Manifest(manifest.get(), ""));

- ASSERT_TRUE(extension);

- ASSERT_EQ(1u, extension->install_warnings().size());

- EXPECT_EQ(feature->GetErrorMessage(Feature::INVALID_MAX_MANIFEST_VERSION),

- extension->install_warnings()[0]);

+ LoadAndExpectWarning(

+ Manifest(manifest.get(), ""),

+ feature->GetErrorMessage(Feature::INVALID_MAX_MANIFEST_VERSION));

}

TEST_F(ExtensionManifestTest, BackgroundAllowNoJsAccess) {