Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: net/dns/dns_config_service_win.cc

Issue 10544054: Fix wierd string iteration problem in ParseDomainASCII under VS2010 debug builds (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/dns/dns_config_service_win.cc
diff --git a/net/dns/dns_config_service_win.cc b/net/dns/dns_config_service_win.cc
index c64f65142953f0db124604f2e0c3378028086973..1e7e49d39813cc728bc990f7cafffb756d94ba84 100644
--- a/net/dns/dns_config_service_win.cc
+++ b/net/dns/dns_config_service_win.cc
@@ -112,7 +112,12 @@ bool ParseDomainASCII(const string16& widestr, std::string* domain) {
// Check if already ASCII.
if (IsStringASCII(widestr)) {
+// http://crbug.com/131599
+#if defined(OS_WIN) && !defined(NDEBUG)
cbentzel 2012/06/07 17:38:46 Can this be fixed with a pragma directive instead?
szym 2012/06/07 17:40:49 Hmm, how about: http://msdn.microsoft.com/en-us/li
+ *domain = UTF16ToASCII(string16(widestr));
+#else
*domain = UTF16ToASCII(widestr);
+#endif
return true;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698