Fix wierd string iteration problem in ParseDomainASCII under VS2010 debug builds

net/dns/dns_config_service_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/dns/dns_config_service_win.h"
 
 #include <algorithm>
 #include <string>
 
 #include "base/bind.h"
@@ skipping 94 matching lines @@
 // Converts a string16 domain name to ASCII, possibly using punycode.
 // Returns true if the conversion succeeds and output is not empty. In case of
 // failure, |domain| might become dirty.
 bool ParseDomainASCII(const string16& widestr, std::string* domain) {
   DCHECK(domain);
   if (widestr.empty())
     return false;
 
   // Check if already ASCII.
   if (IsStringASCII(widestr)) {
+// http://crbug.com/131599
+#if defined(OS_WIN) && !defined(NDEBUG)

[cbentzel, 2012/06/07 17:38:46]

Can this be fixed with a pragma directive instead?

[szym, 2012/06/07 17:40:49]

Hmm, how about: http://msdn.microsoft.com/en-us/library/aa985939(v=vs.80).aspx

+    *domain = UTF16ToASCII(string16(widestr));
+#else
     *domain = UTF16ToASCII(widestr);
+#endif
     return true;
   }
 
   // Otherwise try to convert it from IDN to punycode.
   const int kInitialBufferSize = 256;
   url_canon::RawCanonOutputT<char16, kInitialBufferSize> punycode;
   if (!url_canon::IDNToASCII(widestr.data(), widestr.length(), &punycode))
     return false;
 
   // |punycode_output| should now be ASCII; convert it to a std::string.
@@ skipping 424 matching lines @@
 
 }  // namespace internal
 
 // static
 scoped_ptr<DnsConfigService> DnsConfigService::CreateSystemService() {
   return scoped_ptr<DnsConfigService>(new internal::DnsConfigServiceWin());
 }
 
 }  // namespace net