Moving the tabs_module API into a separate directory in api/

Moving the tabs_module API into a separate directory in api/

Also, splitting extension_tab_modules_constants namespace into
extensions::tab_modules_constants.


BUG=101244
TEST=N/A, only moving code, no change in functionality
TBR=sky@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141231

[vabr (Chromium), 2012-06-06 12:50:14]

Hi Benjamin,

Could you please review this move of tabs_module?

If you think I should add an OWNERS file to list specific owners for this part
of API, please let me know.

I am also Cc-ing jstritar@, because he had a couple of recent CL's in this part
of code.

Thanks!

Vaclav

[not at google - send to devlin, 2012-06-06 22:54:23]

Nice, the idea lgtm but I think this should be called "tabs" not "tabs_module";
I presume it's just old code, because the "module" part is an anomaly compared
to how all the other APIs are called.  So like,

.../api/tabs_module -> .../api/tabs
.../api/tabs_module/tabs_module_constants.h -> .../api/tabs/tabs_constants.h
etc.

I hope that it'd be as simple as a find-replace for "tabs_module" -> "tabs",
then a few file moves.

Also, if you want to move *all* the tabs API functions into api/tabs, you'll
also need to move execute_code_in_tab_function. Which I think would make sense.

Obviously you'll also need OWNERS for ui/ but since it's just a few #includes
fine to TBR I'd expect.

And to answer question about OWNERS, no I think the OWNERS on extensions/ should
be enough.

[vabr (Chromium), 2012-06-08 12:27:26]

Hi Benjamin,
Thanks for your suggestions! I removed "module" from the names, moved
execute_code_in_tab_function to api/tabs, and also corrected the order of the
renamed #includes.
PTAL.

Hi Scott,
Could you please review the part of this CL which does _not_ touch
c/b/extensions?
It is just a bunch of #includes changed due to renaming of files in "tabs"
extension API. Some no longer used #includes were removed.
(You are, of course, welcome to take a look anywhere in the CL, but kalman@ is
already reviewing the c/b/extensions part.)

Thanks,

Vaclav

[not at google - send to devlin, 2012-06-08 12:56:48]

still lgtm.

It's common practice to TBR for trivial changes like #include paths, so I don't
think you need to ask for any other reviewers, just TBR sky and commit.

[vabr (Chromium), 2012-06-08 16:29:30]

On 2012/06/08 12:56:48, kalman wrote:
> still lgtm.
> 
> It's common practice to TBR for trivial changes like #include paths, so I
don't
> think you need to ask for any other reviewers, just TBR sky and commit.

Thanks!

Scott, I did as kalman@ advised. Please take a look once convenient for you.

Cheers,

Vaclav

[commit-bot: I haz the power, 2012-06-08 16:29:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vabr@chromium.org/10544023/12003

[commit-bot: I haz the power, 2012-06-08 17:36:29]

Change committed as 141231