Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.h

Issue 10544023: Moving the tabs_module API into a separate directory in api/ (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Correcting the order of includes. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_API_OFFSCREEN_TABS_OFFSCREEN_TABS_API_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_API_OFFSCREEN_TABS_OFFSCREEN_TABS_API_H_
6 #define CHROME_BROWSER_EXTENSIONS_API_OFFSCREEN_TABS_OFFSCREEN_TABS_API_H_ 6 #define CHROME_BROWSER_EXTENSIONS_API_OFFSCREEN_TABS_OFFSCREEN_TABS_API_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
11 #include "base/values.h" 11 #include "base/values.h"
12 #include "chrome/browser/extensions/api/tabs/tabs.h"
12 #include "chrome/browser/extensions/extension_function.h" 13 #include "chrome/browser/extensions/extension_function.h"
13 #include "chrome/browser/extensions/extension_tabs_module.h"
14 #include "content/public/browser/notification_observer.h" 14 #include "content/public/browser/notification_observer.h"
15 #include "content/public/browser/notification_registrar.h" 15 #include "content/public/browser/notification_registrar.h"
16 #include "content/public/browser/web_contents_observer.h" 16 #include "content/public/browser/web_contents_observer.h"
17 17
18 // The offscreen tabs module depends on the tabs module so we can share 18 // The offscreen tabs module depends on the tabs module so we can share
19 // code between them. The long-term goal is to fold the offscreen tabs 19 // code between them. The long-term goal is to fold the offscreen tabs
20 // functionality into the tabs API. While these methods seem very similar to 20 // functionality into the tabs API. While these methods seem very similar to
21 // those in tabs, there are a few key differences that need to be resolved. 21 // those in tabs, there are a few key differences that need to be resolved.
22 // - Offscreen tabs are invisible (maybe this could be a property on Tab). 22 // - Offscreen tabs are invisible (maybe this could be a property on Tab).
23 // - The lifetime of an offscreen tab is tied to the parent tab that opened 23 // - The lifetime of an offscreen tab is tied to the parent tab that opened
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 virtual bool RunImpl() OVERRIDE; 174 virtual bool RunImpl() OVERRIDE;
175 175
176 // UpdateTabFunction: 176 // UpdateTabFunction:
177 virtual void PopulateResult() OVERRIDE; 177 virtual void PopulateResult() OVERRIDE;
178 178
179 private: 179 private:
180 DISALLOW_COPY_AND_ASSIGN(UpdateOffscreenTabFunction); 180 DISALLOW_COPY_AND_ASSIGN(UpdateOffscreenTabFunction);
181 }; 181 };
182 182
183 #endif // CHROME_BROWSER_EXTENSIONS_API_OFFSCREEN_TABS_OFFSCREEN_TABS_API_H_ 183 #endif // CHROME_BROWSER_EXTENSIONS_API_OFFSCREEN_TABS_OFFSCREEN_TABS_API_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698