Disable the new window context menu option in the bookmarks extension for Windows 8 metro mode.

Disable the new window context menu option in the bookmarks extension for Windows 8 metro mode.
This is done via a new bookmark extension api "experimental.bookmarkManager.canOpenNewWindows" which
returns false for metro mode.

The other change is to ensure that we first look for an existing browser window for the desired
profile when an unnamed extension creates a window in Windows 8 metro mode.

This is to prevent new windows from being created in Windows 8 metro mode.

BUG=124404
R=sky,aa
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140864

[Aaron Boodman, 2012-06-06 01:46:26]

lgtm

http://codereview.chromium.org/10544021/diff/4002/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_tabs_module.cc (right):

http://codereview.chromium.org/10544021/diff/4002/chrome/browser/extensions/e...
chrome/browser/extensions/extension_tabs_module.cc:236: new_window =
browser::FindTabbedBrowser(profile, false);
Document the magic boolean or make it a named constant.

http://codereview.chromium.org/10544021/diff/4002/chrome/browser/resources/bo...
File chrome/browser/resources/bookmark_manager/js/main.js (right):

http://codereview.chromium.org/10544021/diff/4002/chrome/browser/resources/bo...
chrome/browser/resources/bookmark_manager/js/main.js:858:
chrome.experimental.bookmarkManager.canOpenNewWindows(function (result) {
nit: remove space after 'n'.

[ananta, 2012-06-06 01:52:22]

https://chromiumcodereview.appspot.com/10544021/diff/4002/chrome/browser/exte...
File chrome/browser/extensions/extension_tabs_module.cc (right):

https://chromiumcodereview.appspot.com/10544021/diff/4002/chrome/browser/exte...
chrome/browser/extensions/extension_tabs_module.cc:236: new_window =
browser::FindTabbedBrowser(profile, false);
On 2012/06/06 01:46:26, Aaron Boodman wrote:
> Document the magic boolean or make it a named constant.

Done.

https://chromiumcodereview.appspot.com/10544021/diff/4002/chrome/browser/reso...
File chrome/browser/resources/bookmark_manager/js/main.js (right):

https://chromiumcodereview.appspot.com/10544021/diff/4002/chrome/browser/reso...
chrome/browser/resources/bookmark_manager/js/main.js:858:
chrome.experimental.bookmarkManager.canOpenNewWindows(function (result) {
On 2012/06/06 01:46:26, Aaron Boodman wrote:
> nit: remove space after 'n'.

Done.

[sky, 2012-06-06 04:06:15]

LGTM

[James Hawkins, 2012-06-06 22:24:55]

lgtm