chrome/browser/bookmarks/bookmark_manager_extension_api.cc - Issue 10544021: Disable the new window context menu option in the bookmarks extension for Windows 8 metro mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/bookmarks/bookmark_manager_extension_api.cc

Issue 10544021: Disable the new window context menu option in the bookmarks extension for Windows 8 metro mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/bookmarks/bookmark_manager_extension_api.h ('k') | chrome/browser/extensions/extension_function_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/bookmarks/bookmark_manager_extension_api.cc

===================================================================

--- chrome/browser/bookmarks/bookmark_manager_extension_api.cc (revision 140583)

+++ chrome/browser/bookmarks/bookmark_manager_extension_api.cc (working copy)

@@ -29,6 +29,10 @@

#include "grit/generated_resources.h"

#include "ui/base/l10n/l10n_util.h"

+#if defined(OS_WIN)

+#include "base/win/metro.h"

+#endif // OS_WIN

namespace keys = bookmark_extension_api_constants;

using content::WebContents;

@@ -500,3 +504,15 @@

bookmark_utils::RecordBookmarkLaunch(bookmark_utils::LAUNCH_MANAGER);

return true;

}

+bool CanOpenNewWindowsBookmarkFunction::RunImpl() {

+ bool can_open_new_windows = true;

+#if defined(OS_WIN)

+ if (base::win::GetMetroModule())

+ can_open_new_windows = false;

+#endif // OS_WIN

+ result_.reset(Value::CreateBooleanValue(can_open_new_windows));

+ return true;