runtime/vm/flow_graph_compiler.cc - Issue 10543111: Optimize StoreIndexedComp on ia32&x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler.cc

Issue 10543111: Optimize StoreIndexedComp on ia32&x64. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: disable store indexed specialization if FLAG_enable_type_checks Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_compiler.cc

diff --git a/runtime/vm/flow_graph_compiler.cc b/runtime/vm/flow_graph_compiler.cc

index f5cd3f3231f6bb91e6d9282c7d53498449cdc41a..d127ee4dec0a9707d3f1126da1d1b19f428a1cef 100644

--- a/runtime/vm/flow_graph_compiler.cc

+++ b/runtime/vm/flow_graph_compiler.cc

@@ -154,11 +154,13 @@ Label* FlowGraphCompiler::AddDeoptStub(intptr_t deopt_id,

intptr_t try_index,

DeoptReasonId reason,

- Register reg2) {

+ Register reg2,

+ Register reg3) {

DeoptimizationStub* stub =

new DeoptimizationStub(deopt_id, deopt_token_index, try_index, reason);

stub->Push(reg1);

srdjan 2012/06/12 16:43:46 I think we need to guard reg2 as well for kNoRegis

stub->Push(reg2);

+ if (reg3 != kNoRegister) stub->Push(reg3);

deopt_stubs_.Add(stub);

return stub->entry_label();

}