Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Side by Side Diff: runtime/vm/flow_graph_compiler.cc

Issue 10543111: Optimize StoreIndexedComp on ia32&x64. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: disable store indexed specialization if FLAG_enable_type_checks Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_XXX. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_XXX.
6 6
7 #include "vm/flow_graph_compiler.h" 7 #include "vm/flow_graph_compiler.h"
8 8
9 #include "vm/debugger.h" 9 #include "vm/debugger.h"
10 #include "vm/il_printer.h" 10 #include "vm/il_printer.h"
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 token_index, 147 token_index,
148 try_index); 148 try_index);
149 } 149 }
150 150
151 151
152 Label* FlowGraphCompiler::AddDeoptStub(intptr_t deopt_id, 152 Label* FlowGraphCompiler::AddDeoptStub(intptr_t deopt_id,
153 intptr_t deopt_token_index, 153 intptr_t deopt_token_index,
154 intptr_t try_index, 154 intptr_t try_index,
155 DeoptReasonId reason, 155 DeoptReasonId reason,
156 Register reg1, 156 Register reg1,
157 Register reg2) { 157 Register reg2,
158 Register reg3) {
158 DeoptimizationStub* stub = 159 DeoptimizationStub* stub =
159 new DeoptimizationStub(deopt_id, deopt_token_index, try_index, reason); 160 new DeoptimizationStub(deopt_id, deopt_token_index, try_index, reason);
160 stub->Push(reg1); 161 stub->Push(reg1);
srdjan 2012/06/12 16:43:46 I think we need to guard reg2 as well for kNoRegis
161 stub->Push(reg2); 162 stub->Push(reg2);
163 if (reg3 != kNoRegister) stub->Push(reg3);
162 deopt_stubs_.Add(stub); 164 deopt_stubs_.Add(stub);
163 return stub->entry_label(); 165 return stub->entry_label();
164 } 166 }
165 167
166 168
167 void FlowGraphCompiler::FinalizeExceptionHandlers(const Code& code) { 169 void FlowGraphCompiler::FinalizeExceptionHandlers(const Code& code) {
168 ASSERT(exception_handlers_list_ != NULL); 170 ASSERT(exception_handlers_list_ != NULL);
169 const ExceptionHandlers& handlers = ExceptionHandlers::Handle( 171 const ExceptionHandlers& handlers = ExceptionHandlers::Handle(
170 exception_handlers_list_->FinalizeExceptionHandlers(code.EntryPoint())); 172 exception_handlers_list_->FinalizeExceptionHandlers(code.EntryPoint()));
171 code.set_exception_handlers(handlers); 173 code.set_exception_handlers(handlers);
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
358 360
359 361
360 void FlowGraphCompiler::EmitComment(Instruction* instr) { 362 void FlowGraphCompiler::EmitComment(Instruction* instr) {
361 char buffer[80]; 363 char buffer[80];
362 BufferFormatter f(buffer, sizeof(buffer)); 364 BufferFormatter f(buffer, sizeof(buffer));
363 instr->PrintTo(&f); 365 instr->PrintTo(&f);
364 assembler()->Comment("@%d: %s", instr->cid(), buffer); 366 assembler()->Comment("@%d: %s", instr->cid(), buffer);
365 } 367 }
366 368
367 } // namespace dart 369 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler_ia32.h » ('j') | runtime/vm/flow_graph_compiler_ia32.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698