Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: utils/compiler/buildbot.py

Issue 10543027: Fixes for checked mode and change buildbot script to run dart2js tests in checked mode also. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/standalone.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/compiler/buildbot.py
===================================================================
--- utils/compiler/buildbot.py (revision 8378)
+++ utils/compiler/buildbot.py (working copy)
@@ -277,8 +277,8 @@
# First we run all the regular tests.
status = TestCompiler(compiler, runtime, mode, system, option, test_flags)
- # BUG(3281): We do not run checked mode tests on dart2js.
- if status == 0 and compiler != 'dart2js':
+ # We only run checked mode tests when the host is not in checked mode.
+ if status == 0 and option != 'checked' and runtime == 'd8':
status = TestCompiler(compiler, runtime, mode, system, option,
test_flags + ['--checked'])
« no previous file with comments | « tests/standalone/standalone.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698