NetLogEventParameter to Callback refactoring 11.

NetLogEventParameter to Callback refactoring 11. 
Get rid of all uses of NetLog::EventParameters in 
all remaining locations (downloads, appcache, io thread, 
chrome_network_delegate.

R=eroman@chromium.org,rdsmith@chromium.org,michaeln@chromium.org
BUG=126243
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142217

[mmenke, 2012-06-14 15:00:35]

Eric:  Please review everything.
Randy:  Please review downloads.
Michael:  Please review appcache (A daunting task).

[eroman, 2012-06-14 18:04:31]

lgtm

http://codereview.chromium.org/10542153/diff/10001/chrome/browser/net/chrome_...
File chrome/browser/net/chrome_network_delegate.cc (right):

http://codereview.chromium.org/10542153/diff/10001/chrome/browser/net/chrome_...
chrome/browser/net/chrome_network_delegate.cc:174:
net::NetLog::StringCallback("url", &request->url().spec()));
nit: might want to use possibly_invalid_spec() just in case

http://codereview.chromium.org/10542153/diff/10001/chrome/browser/net/chrome_...
chrome/browser/net/chrome_network_delegate.cc:383:
net::NetLog::StringCallback("url", &socket->url().spec()));
ditto.

http://codereview.chromium.org/10542153/diff/10001/net/base/net_log.h
File net/base/net_log.h (right):

http://codereview.chromium.org/10542153/diff/10001/net/base/net_log.h#newcode301
net/base/net_log.h:301: static ParametersCallback IntegerCallback(const char*
name, int value);
We may want to add a todo to rename this to Int32Callback, for consistency.

[Randy Smith (Not in Mondays), 2012-06-14 18:14:55]

lgtm

[michaeln, 2012-06-14 18:48:26]

lgtm

[mmenke, 2012-06-14 18:49:36]

Thanks!

[mmenke, 2012-06-14 18:49:42]

https://chromiumcodereview.appspot.com/10542153/diff/10001/chrome/browser/net...
File chrome/browser/net/chrome_network_delegate.cc (right):

https://chromiumcodereview.appspot.com/10542153/diff/10001/chrome/browser/net...
chrome/browser/net/chrome_network_delegate.cc:174:
net::NetLog::StringCallback("url", &request->url().spec()));
On 2012/06/14 18:04:31, eroman wrote:
> nit: might want to use possibly_invalid_spec() just in case

Done.

https://chromiumcodereview.appspot.com/10542153/diff/10001/chrome/browser/net...
chrome/browser/net/chrome_network_delegate.cc:383:
net::NetLog::StringCallback("url", &socket->url().spec()));
On 2012/06/14 18:04:31, eroman wrote:
> ditto.

Done.

https://chromiumcodereview.appspot.com/10542153/diff/10001/net/base/net_log.h
File net/base/net_log.h (right):

https://chromiumcodereview.appspot.com/10542153/diff/10001/net/base/net_log.h...
net/base/net_log.h:301: static ParametersCallback IntegerCallback(const char*
name, int value);
On 2012/06/14 18:04:31, eroman wrote:
> We may want to add a todo to rename this to Int32Callback, for consistency.

TODO added.

[commit-bot: I haz the power, 2012-06-14 18:50:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmenke@chromium.org/10542153/4014

[commit-bot: I haz the power, 2012-06-14 20:56:28]

Change committed as 142217