Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1207)

Unified Diff: net/base/net_log.h

Issue 10542153: NetLogEventParameter to Callback refactoring 11. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Response to comments Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/download/download_net_log_parameters.cc ('k') | net/base/net_log.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/net_log.h
===================================================================
--- net/base/net_log.h (revision 142108)
+++ net/base/net_log.h (working copy)
@@ -298,8 +298,15 @@
// Creates a ParametersCallback that encapsulates a single integer.
// Warning: |name| must remain valid for the life of the callback.
+ // TODO(mmenke): Rename this to be consistent with Int64Callback.
static ParametersCallback IntegerCallback(const char* name, int value);
+ // Creates a ParametersCallback that encapsulates a single int64. The
+ // callback will return the value as a StringValue, since IntegerValues
+ // only support 32-bit values.
+ // Warning: |name| must remain valid for the life of the callback.
+ static ParametersCallback Int64Callback(const char* name, int64 value);
+
// Creates a ParametersCallback that encapsulates a single UTF8 string. Takes
// |value| as a pointer to avoid copying, and emphasize it must be valid for
// the life of the callback. |value| may not be NULL.
« no previous file with comments | « content/browser/download/download_net_log_parameters.cc ('k') | net/base/net_log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698