Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 10542105: TabContentsWrapper -> TabContents, part 42. (Closed)

Created:
8 years, 6 months ago by Avi (use Gerrit)
Modified:
8 years, 6 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews
Visibility:
Public.

Description

TabContentsWrapper -> TabContents, part 42. browser/ui/intents BUG=131026 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141480

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -53 lines) Patch
M chrome/browser/ui/cocoa/web_intent_sheet_controller.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/intents/web_intent_inline_disposition_delegate_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller.h View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller.cc View 19 chunks +35 lines, -34 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc View 6 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Avi (use Gerrit)
8 years, 6 months ago (2012-06-11 17:55:47 UTC) #1
James Hawkins
LGTM
8 years, 6 months ago (2012-06-11 18:46:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10542105/6001
8 years, 6 months ago (2012-06-11 19:00:17 UTC) #3
commit-bot: I haz the power
Failed to apply patch for chrome/browser/ui/cocoa/web_intent_sheet_controller.h: While running patch -p1 --forward --force; patching file chrome/browser/ui/cocoa/web_intent_sheet_controller.h ...
8 years, 6 months ago (2012-06-11 19:00:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10542105/11002
8 years, 6 months ago (2012-06-11 19:03:24 UTC) #5
commit-bot: I haz the power
8 years, 6 months ago (2012-06-11 20:28:57 UTC) #6
Change committed as 141480

Powered by Google App Engine
This is Rietveld 408576698