Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Side by Side Diff: chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc

Issue 10542105: TabContentsWrapper -> TabContents, part 42. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/intents/web_intent_picker_controller.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <algorithm> 5 #include <algorithm>
6 #include <iterator> 6 #include <iterator>
7 7
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/callback.h" 9 #include "base/callback.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
11 #include "base/string_util.h" 11 #include "base/string_util.h"
12 #include "base/stringprintf.h" 12 #include "base/stringprintf.h"
13 #include "base/utf_string_conversions.h" 13 #include "base/utf_string_conversions.h"
14 #include "chrome/browser/favicon/favicon_service.h" 14 #include "chrome/browser/favicon/favicon_service.h"
15 #include "chrome/browser/intents/default_web_intent_service.h" 15 #include "chrome/browser/intents/default_web_intent_service.h"
16 #include "chrome/browser/profiles/profile.h" 16 #include "chrome/browser/profiles/profile.h"
17 #include "chrome/browser/ui/browser.h" 17 #include "chrome/browser/ui/browser.h"
18 #include "chrome/browser/ui/intents/web_intent_picker.h" 18 #include "chrome/browser/ui/intents/web_intent_picker.h"
19 #include "chrome/browser/ui/intents/web_intent_picker_controller.h" 19 #include "chrome/browser/ui/intents/web_intent_picker_controller.h"
20 #include "chrome/browser/ui/intents/web_intent_picker_model.h" 20 #include "chrome/browser/ui/intents/web_intent_picker_model.h"
21 #include "chrome/browser/ui/intents/web_intent_picker_model_observer.h" 21 #include "chrome/browser/ui/intents/web_intent_picker_model_observer.h"
22 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" 22 #include "chrome/browser/ui/tab_contents/tab_contents.h"
23 #include "chrome/browser/webdata/web_data_service.h" 23 #include "chrome/browser/webdata/web_data_service.h"
24 #include "chrome/browser/webdata/web_data_service_factory.h" 24 #include "chrome/browser/webdata/web_data_service_factory.h"
25 #include "chrome/common/chrome_switches.h" 25 #include "chrome/common/chrome_switches.h"
26 #include "chrome/common/url_constants.h" 26 #include "chrome/common/url_constants.h"
27 #include "chrome/test/base/in_process_browser_test.h" 27 #include "chrome/test/base/in_process_browser_test.h"
28 #include "chrome/test/base/ui_test_utils.h" 28 #include "chrome/test/base/ui_test_utils.h"
29 #include "content/public/browser/web_contents.h" 29 #include "content/public/browser/web_contents.h"
30 #include "content/public/browser/web_intents_dispatcher.h" 30 #include "content/public/browser/web_intents_dispatcher.h"
31 #include "content/public/test/test_url_fetcher_factory.h" 31 #include "content/public/test/test_url_fetcher_factory.h"
32 #include "net/base/escape.h" 32 #include "net/base/escape.h"
(...skipping 196 matching lines...) Expand 10 before | Expand all | Expand 10 after
229 // Instead, use this dummy factory to infinitely delay the request. 229 // Instead, use this dummy factory to infinitely delay the request.
230 default_url_fetcher_factory_.reset(new DummyURLFetcherFactory); 230 default_url_fetcher_factory_.reset(new DummyURLFetcherFactory);
231 fake_url_fetcher_factory_.reset( 231 fake_url_fetcher_factory_.reset(
232 new FakeURLFetcherFactory(default_url_fetcher_factory_.get())); 232 new FakeURLFetcherFactory(default_url_fetcher_factory_.get()));
233 233
234 web_data_service_ = WebDataServiceFactory::GetForProfile( 234 web_data_service_ = WebDataServiceFactory::GetForProfile(
235 GetBrowser()->profile(), Profile::EXPLICIT_ACCESS); 235 GetBrowser()->profile(), Profile::EXPLICIT_ACCESS);
236 favicon_service_ = 236 favicon_service_ =
237 GetBrowser()->profile()->GetFaviconService(Profile::EXPLICIT_ACCESS); 237 GetBrowser()->profile()->GetFaviconService(Profile::EXPLICIT_ACCESS);
238 controller_ = GetBrowser()-> 238 controller_ = GetBrowser()->
239 GetSelectedTabContentsWrapper()->web_intent_picker_controller(); 239 GetActiveTabContents()->web_intent_picker_controller();
240 240
241 SetupMockPicker(); 241 SetupMockPicker();
242 controller_->set_model_observer(&picker_); 242 controller_->set_model_observer(&picker_);
243 picker_.delegate_ = controller_; 243 picker_.delegate_ = controller_;
244 244
245 CreateFakeIcon(); 245 CreateFakeIcon();
246 } 246 }
247 247
248 virtual void SetupMockPicker() { 248 virtual void SetupMockPicker() {
249 controller_->set_picker(&picker_); 249 controller_->set_picker(&picker_);
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
344 344
345 webkit_glue::WebIntentData intent; 345 webkit_glue::WebIntentData intent;
346 intent.action = ASCIIToUTF16("a"); 346 intent.action = ASCIIToUTF16("a");
347 intent.type = ASCIIToUTF16("b"); 347 intent.type = ASCIIToUTF16("b");
348 IntentsDispatcherMock dispatcher(intent); 348 IntentsDispatcherMock dispatcher(intent);
349 controller_->SetIntentsDispatcher(&dispatcher); 349 controller_->SetIntentsDispatcher(&dispatcher);
350 350
351 OnServiceChosen(kServiceURL2, WebIntentPickerModel::DISPOSITION_WINDOW); 351 OnServiceChosen(kServiceURL2, WebIntentPickerModel::DISPOSITION_WINDOW);
352 ASSERT_EQ(2, browser()->tab_count()); 352 ASSERT_EQ(2, browser()->tab_count());
353 EXPECT_EQ(GURL(kServiceURL2), 353 EXPECT_EQ(GURL(kServiceURL2),
354 browser()->GetSelectedWebContents()->GetURL()); 354 browser()->GetActiveWebContents()->GetURL());
355 355
356 EXPECT_TRUE(dispatcher.dispatched_); 356 EXPECT_TRUE(dispatcher.dispatched_);
357 357
358 OnSendReturnMessage(webkit_glue::WEB_INTENT_REPLY_SUCCESS); 358 OnSendReturnMessage(webkit_glue::WEB_INTENT_REPLY_SUCCESS);
359 ASSERT_EQ(1, browser()->tab_count()); 359 ASSERT_EQ(1, browser()->tab_count());
360 } 360 }
361 361
362 IN_PROC_BROWSER_TEST_F(WebIntentPickerControllerBrowserTest, 362 IN_PROC_BROWSER_TEST_F(WebIntentPickerControllerBrowserTest,
363 FetchExtensionIcon) { 363 FetchExtensionIcon) {
364 AddWebIntentService(kAction1, kServiceURL1); 364 AddWebIntentService(kAction1, kServiceURL1);
(...skipping 18 matching lines...) Expand all
383 383
384 controller_->ShowDialog(kAction1, kType1); 384 controller_->ShowDialog(kAction1, kType1);
385 OnCancelled(); 385 OnCancelled();
386 } 386 }
387 387
388 IN_PROC_BROWSER_TEST_F(WebIntentPickerControllerBrowserTest, 388 IN_PROC_BROWSER_TEST_F(WebIntentPickerControllerBrowserTest,
389 CloseTargetTabReturnToSource) { 389 CloseTargetTabReturnToSource) {
390 AddWebIntentService(kAction1, kServiceURL1); 390 AddWebIntentService(kAction1, kServiceURL1);
391 AddCWSExtensionServiceEmpty(kAction1); 391 AddCWSExtensionServiceEmpty(kAction1);
392 392
393 GURL original = browser()->GetSelectedWebContents()->GetURL(); 393 GURL original = browser()->GetActiveWebContents()->GetURL();
394 394
395 // Open a new page, but keep focus on original. 395 // Open a new page, but keep focus on original.
396 ui_test_utils::NavigateToURLWithDisposition( 396 ui_test_utils::NavigateToURLWithDisposition(
397 browser(), GURL(chrome::kChromeUINewTabURL), NEW_BACKGROUND_TAB, 397 browser(), GURL(chrome::kChromeUINewTabURL), NEW_BACKGROUND_TAB,
398 ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION); 398 ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
399 ASSERT_EQ(2, browser()->tab_count()); 399 ASSERT_EQ(2, browser()->tab_count());
400 EXPECT_EQ(original, browser()->GetSelectedWebContents()->GetURL()); 400 EXPECT_EQ(original, browser()->GetActiveWebContents()->GetURL());
401 401
402 controller_->ShowDialog(kAction1, kType1); 402 controller_->ShowDialog(kAction1, kType1);
403 picker_.Wait(); 403 picker_.Wait();
404 EXPECT_EQ(1, picker_.num_installed_services_); 404 EXPECT_EQ(1, picker_.num_installed_services_);
405 405
406 webkit_glue::WebIntentData intent; 406 webkit_glue::WebIntentData intent;
407 intent.action = ASCIIToUTF16("a"); 407 intent.action = ASCIIToUTF16("a");
408 intent.type = ASCIIToUTF16("b"); 408 intent.type = ASCIIToUTF16("b");
409 IntentsDispatcherMock dispatcher(intent); 409 IntentsDispatcherMock dispatcher(intent);
410 controller_->SetIntentsDispatcher(&dispatcher); 410 controller_->SetIntentsDispatcher(&dispatcher);
411 411
412 OnServiceChosen(kServiceURL1, WebIntentPickerModel::DISPOSITION_WINDOW); 412 OnServiceChosen(kServiceURL1, WebIntentPickerModel::DISPOSITION_WINDOW);
413 ASSERT_EQ(3, browser()->tab_count()); 413 ASSERT_EQ(3, browser()->tab_count());
414 EXPECT_EQ(GURL(kServiceURL1), 414 EXPECT_EQ(GURL(kServiceURL1),
415 browser()->GetSelectedWebContents()->GetURL()); 415 browser()->GetActiveWebContents()->GetURL());
416 416
417 EXPECT_TRUE(dispatcher.dispatched_); 417 EXPECT_TRUE(dispatcher.dispatched_);
418 418
419 OnSendReturnMessage(webkit_glue::WEB_INTENT_REPLY_SUCCESS); 419 OnSendReturnMessage(webkit_glue::WEB_INTENT_REPLY_SUCCESS);
420 ASSERT_EQ(2, browser()->tab_count()); 420 ASSERT_EQ(2, browser()->tab_count());
421 EXPECT_EQ(original, browser()->GetSelectedWebContents()->GetURL()); 421 EXPECT_EQ(original, browser()->GetActiveWebContents()->GetURL());
422 } 422 }
423 423
424 class WebIntentPickerControllerIncognitoBrowserTest : 424 class WebIntentPickerControllerIncognitoBrowserTest :
425 public WebIntentPickerControllerBrowserTest { 425 public WebIntentPickerControllerBrowserTest {
426 public: 426 public:
427 WebIntentPickerControllerIncognitoBrowserTest() {} 427 WebIntentPickerControllerIncognitoBrowserTest() {}
428 428
429 virtual void SetUpOnMainThread() OVERRIDE { 429 virtual void SetUpOnMainThread() OVERRIDE {
430 incognito_browser_ = CreateIncognitoBrowser(); 430 incognito_browser_ = CreateIncognitoBrowser();
431 WebIntentPickerControllerBrowserTest::SetUpOnMainThread(); 431 WebIntentPickerControllerBrowserTest::SetUpOnMainThread();
(...skipping 157 matching lines...) Expand 10 before | Expand all | Expand 10 after
589 ui_test_utils::WindowedTabAddedNotificationObserver new_tab_observer(( 589 ui_test_utils::WindowedTabAddedNotificationObserver new_tab_observer((
590 content::Source<content::WebContentsDelegate>(browser()))); 590 content::Source<content::WebContentsDelegate>(browser())));
591 controller_->ShowDialog(kAction1, kType1); 591 controller_->ShowDialog(kAction1, kType1);
592 new_tab_observer.Wait(); 592 new_tab_observer.Wait();
593 593
594 EXPECT_EQ(2, picker_.num_installed_services_); 594 EXPECT_EQ(2, picker_.num_installed_services_);
595 595
596 // The tab is shown immediately without needing to call OnServiceChosen. 596 // The tab is shown immediately without needing to call OnServiceChosen.
597 ASSERT_EQ(2, browser()->tab_count()); 597 ASSERT_EQ(2, browser()->tab_count());
598 EXPECT_EQ(GURL(kServiceURL1), 598 EXPECT_EQ(GURL(kServiceURL1),
599 browser()->GetSelectedWebContents()->GetURL()); 599 browser()->GetActiveWebContents()->GetURL());
600 600
601 EXPECT_TRUE(dispatcher.dispatched_); 601 EXPECT_TRUE(dispatcher.dispatched_);
602 } 602 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/intents/web_intent_picker_controller.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698