Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10542081: Coverity: Restructure logically dead code. (Closed)

Created:
8 years, 6 months ago by kmadhusu
Modified:
8 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org
Visibility:
Public.

Description

Coverity: Restructure logically dead code. CID=102349 TEST=none BUG=none TBR=miletus@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141301

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M content/browser/geolocation/libgps_wrapper_linux.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kmadhusu
8 years, 6 months ago (2012-06-08 20:06:37 UTC) #1
joth
https://chromiumcodereview.appspot.com/10542081/diff/1/content/browser/geolocation/libgps_wrapper_linux.cc File content/browser/geolocation/libgps_wrapper_linux.cc (left): https://chromiumcodereview.appspot.com/10542081/diff/1/content/browser/geolocation/libgps_wrapper_linux.cc#oldcode91 content/browser/geolocation/libgps_wrapper_linux.cc:91: return true; this is still needed for the OS_CHROMEOS ...
8 years, 6 months ago (2012-06-08 20:39:00 UTC) #2
kmadhusu
https://chromiumcodereview.appspot.com/10542081/diff/1/content/browser/geolocation/libgps_wrapper_linux.cc File content/browser/geolocation/libgps_wrapper_linux.cc (left): https://chromiumcodereview.appspot.com/10542081/diff/1/content/browser/geolocation/libgps_wrapper_linux.cc#oldcode91 content/browser/geolocation/libgps_wrapper_linux.cc:91: return true; On 2012/06/08 20:39:00, joth wrote: > this ...
8 years, 6 months ago (2012-06-08 20:47:32 UTC) #3
joth
lgtm
8 years, 6 months ago (2012-06-08 20:49:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/10542081/4001
8 years, 6 months ago (2012-06-08 20:52:04 UTC) #5
commit-bot: I haz the power
8 years, 6 months ago (2012-06-08 22:12:56 UTC) #6 
Change committed as 141301

Powered by Google App Engine
This is Rietveld 408576698