Coverity: Restructure logically dead code.

content/browser/geolocation/libgps_wrapper_linux.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/geolocation/libgps_wrapper_linux.h"
 
 #include <math.h>
 #include <dlfcn.h>
 #include <errno.h>
 
@@ skipping 68 matching lines @@
   errno = 0;
   if (gps_open_(GPSD_SHARED_MEMORY, 0, gps_data_.get()) != 0) {
     // See gps.h NL_NOxxx for definition of gps_open() error numbers.
     DLOG(WARNING) << "gps_open() failed " << errno;
     return false;
   }
 #else  // drop the support for desktop linux for now
   DLOG(WARNING) << "LibGps is only supported on ChromeOS";
   return false;
 #endif
-
-  is_open_ = true;
-  return true;

[joth, 2012/06/08 20:39:00]

this is still needed for the OS_CHROMEOS case (it should break compilation
without this)

however feel free to move it up inside the #if block.

[kmadhusu, 2012/06/08 20:47:32]

oops.. missed that path.. Fixed now.

 }
 void LibGps::Stop() {
   if (is_open_)
     gps_close_(gps_data_.get());
   is_open_ = false;
 }
 
 bool LibGps::Read(content::Geoposition* position) {
   DCHECK(position);
   position->error_code = content::Geoposition::ERROR_CODE_POSITION_UNAVAILABLE;
@@ skipping 64 matching lines @@
     if (!isnan(gps_data_->fix.epv))
       position->altitude_accuracy = gps_data_->fix.epv;
   }
 
   if (!isnan(gps_data_->fix.track))
     position->heading = gps_data_->fix.track;
   if (!isnan(gps_data_->fix.speed))
     position->speed = gps_data_->fix.speed;
   return true;
 }