Separate out IPC::Message::Sender and channel::Listener into a separate class.

Separate out IPC::Message::Sender and Channel::Listener into a separate class.

I fixed the places that did IPC::Channel::Sender (I don't even know how this compiled, but I presume this means the "Sender" base class of the "Channel" which ends up being right).

We can fix the other users of this later.

BUG=
TEST=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141534

[brettw, 2012-06-07 22:54:12]

I kept being annoyed that I can't forward declare this class.

[jam, 2012-06-08 00:54:28]

wouldn't it be clearer to have IPC::Sender and IPC::Listener?

[brettw, 2012-06-08 19:34:12]

Good idea, done

[commit-bot: I haz the power, 2012-06-08 21:30:41]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[jam, 2012-06-11 01:56:29]

lgtm

i regret that the ipc files all start with "ipc_" which is redundant. up to you
if you want to make the new ones just be ipc/sender.h or if you just want to
leave as is to be consistent

http://codereview.chromium.org/10541065/diff/5001/ipc/ipc_channel_listener.h
File ipc/ipc_channel_listener.h (right):

http://codereview.chromium.org/10541065/diff/5001/ipc/ipc_channel_listener.h#...
ipc/ipc_channel_listener.h:1: // Copyright (c) 2012 The Chromium Authors. All
rights reserved.
nit: shouldn't this be ipc/channel_listener.h to match the IPC::ChannelListener
name?

http://codereview.chromium.org/10541065/diff/9002/ipc/ipc_listener.cc
File ipc/ipc_listener.cc (right):

http://codereview.chromium.org/10541065/diff/9002/ipc/ipc_listener.cc#newcode1
ipc/ipc_listener.cc:1: // Copyright (c) 2012 The Chromium Authors. All rights
reserved.
nit: you don't need this file since you can inline all the methods below (since
there's no return values, clang won't complain)

http://codereview.chromium.org/10541065/diff/9002/ipc/ipc_sender.cc
File ipc/ipc_sender.cc (right):

http://codereview.chromium.org/10541065/diff/9002/ipc/ipc_sender.cc#newcode1
ipc/ipc_sender.cc:1: // Copyright (c) 2012 The Chromium Authors. All rights
reserved.
ditto

[jam, 2012-06-11 03:10:00]

http://codereview.chromium.org/10541065/diff/5001/ipc/ipc_channel_listener.h
File ipc/ipc_channel_listener.h (right):

http://codereview.chromium.org/10541065/diff/5001/ipc/ipc_channel_listener.h#...
ipc/ipc_channel_listener.h:1: // Copyright (c) 2012 The Chromium Authors. All
rights reserved.
On 2012/06/11 01:56:29, John Abd-El-Malek wrote:
> nit: shouldn't this be ipc/channel_listener.h to match the
IPC::ChannelListener
> name?

btw ignore this outdated comment