Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1194)

Unified Diff: ipc/ipc_message.h

Issue 10541065: Separate out IPC::Message::Sender and channel::Listener into a separate class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: de-inline Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/ipc_logging.cc ('k') | ipc/ipc_sender.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_message.h
diff --git a/ipc/ipc_message.h b/ipc/ipc_message.h
index 2c85e42ab75877f1a558624a967ce24ee36d96b3..c3d4296cfe3e3adda857d30ad80d6e201dcc9996 100644
--- a/ipc/ipc_message.h
+++ b/ipc/ipc_message.h
@@ -12,6 +12,9 @@
#include "base/pickle.h"
#include "ipc/ipc_export.h"
+// TODO(brettw) remove this when the "typedef Sender" is removed below.
+#include "ipc/ipc_sender.h"
+
// Ipc logging adds a dependency from the 'chrome' target on all ipc message
// classes. In a component build, this would require exporting all message
// classes, so don't support ipc logging in the components build.
@@ -39,17 +42,11 @@ struct LogData;
class IPC_EXPORT Message : public Pickle {
public:
- // Implemented by objects that can send IPC messages across a channel.
- class IPC_EXPORT Sender {
- public:
- virtual ~Sender() {}
-
- // Sends the given IPC message. The implementor takes ownership of the
- // given Message regardless of whether or not this method succeeds. This
- // is done to make this method easier to use. Returns true on success and
- // false otherwise.
- virtual bool Send(Message* msg) = 0;
- };
+ // IPC::Sender used to be IPC::Message::Sender which prevented forward
+ // declarations. To keep existing code compiling, we provide this backwards-
+ // compatible definition. New code should use IPC::Sender.
+ // TODO(brettw) convert users of this and delete.
+ typedef IPC::Sender Sender;
enum PriorityValue {
PRIORITY_LOW = 1,
« no previous file with comments | « ipc/ipc_logging.cc ('k') | ipc/ipc_sender.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698