Add variables support to trace_test_cases.py, removing the last use of --product-dir.

Add variables support to trace_test_cases.py, removing the last use of --product-dir.

Add --verbose support to trace_test_cases.py.

Clean up isolate dictionary generation and filter known spew. Adds <(EXECUTABLE_SUFFIX) where appropriate.

R=cmp@chromium.org
NOTRY=true
BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142890

[M-A Ruel, 2012-06-15 14:45:02]

Sorry, please do not review yet, I'll change it a bit.

[M-A Ruel, 2012-06-15 15:38:12]

Now good to review!

[cmp, 2012-06-18 21:26:29]

lgtm with nit

http://chromiumcodereview.appspot.com/10540172/diff/7001/tools/isolate/isolat...
File tools/isolate/isolate_common.py (right):

http://chromiumcodereview.appspot.com/10540172/diff/7001/tools/isolate/isolat...
tools/isolate/isolate_common.py:142: 
nit: insert an empty line

[commit-bot: I haz the power, 2012-06-19 01:27:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/10540172/11001

[commit-bot: I haz the power, 2012-06-19 01:27:24]

Presubmit check for 10540172-11001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Please install pylint with "sudo apt-get install python-setuptools; sudo
easy_install pylint"
or visit http://pypi.python.org/pypi/setuptools.
Cannot do static analysis of python files.

Presubmit checks took 6.8s to calculate.

[commit-bot: I haz the power, 2012-06-19 01:33:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/10540172/11001

[commit-bot: I haz the power, 2012-06-19 01:34:17]

Presubmit check for 10540172-11001 failed and returned exit status 1.

************* Module run_test_cases
F0401: 30,0: Unable to import 'subprocess2'
Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Fix pylint errors first.

Presubmit checks took 13.5s to calculate.

[commit-bot: I haz the power, 2012-06-19 01:44:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/10540172/11001

[commit-bot: I haz the power, 2012-06-19 01:44:12]

Presubmit check for 10540172-11001 failed and returned exit status 1.

Running presubmit commit checks ...
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 43, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1257, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1105, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1022, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 28, in CheckChangeOnCommit
  File "<string>", line 14, in CommonChecks
  File "/b/depot_tools/presubmit_canned_checks.py", line 648, in RunPylint
    env['PYTHONPATH'] = os.pathsep.join(sys.path)
NameError: global name 'os' is not defined

[commit-bot: I haz the power, 2012-06-19 01:46:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/10540172/11001

[commit-bot: I haz the power, 2012-06-19 01:46:58]

Presubmit check for 10540172-11001 failed and returned exit status 1.

Running presubmit commit checks ...
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 43, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1257, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1105, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1022, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 28, in CheckChangeOnCommit
  File "<string>", line 14, in CommonChecks
  File "/b/depot_tools/presubmit_canned_checks.py", line 648, in RunPylint
    env['PYTHONPATH'] = input_api.os.pathsep.join(sys.path)
AttributeError: 'InputApi' object has no attribute 'os'

[commit-bot: I haz the power, 2012-06-19 01:47:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/10540172/11001

[commit-bot: I haz the power, 2012-06-19 01:47:39]

Presubmit check for 10540172-11001 failed and returned exit status 1.

Running presubmit commit checks ...
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 43, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1257, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1105, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1022, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 28, in CheckChangeOnCommit
  File "<string>", line 14, in CommonChecks
  File "/b/depot_tools/presubmit_canned_checks.py", line 648, in RunPylint
    env['PYTHONPATH'] = input_api.os_path.pathsep.join(sys.path)
NameError: global name 'sys' is not defined

[commit-bot: I haz the power, 2012-06-19 01:48:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/10540172/11001

[commit-bot: I haz the power, 2012-06-19 01:49:11]

Change committed as 142890

[M-A Ruel, 2012-06-19 01:51:18]

On 2012/06/19 01:49:11, I haz the power (commit-bot) wrote:
> Change committed as 142890

(Sorry for using this CL to debug the CQ. :)