Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: tools/isolate/trace_test_cases_smoke_test.py

Issue 10540172: Add variables support to trace_test_cases.py, removing the last use of --product-dir. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/isolate/trace_test_cases.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/isolate/trace_test_cases_smoke_test.py
diff --git a/tools/isolate/trace_test_cases_smoke_test.py b/tools/isolate/trace_test_cases_smoke_test.py
index faa11130062329b28e89386169efa5012284956b..57faf23c73e47c3112897340e180694855241475 100755
--- a/tools/isolate/trace_test_cases_smoke_test.py
+++ b/tools/isolate/trace_test_cases_smoke_test.py
@@ -109,9 +109,11 @@ class TraceTestCases(unittest.TestCase):
'--out', self.temp_file,
'--root-dir', ROOT_DIR,
'--cwd', ROOT_DIR,
- '--product-dir', 'data',
+ '--variable', 'PRODUCT_DIR', 'data',
TARGET_PATH,
]
+ if VERBOSE:
+ cmd.extend(['-v'] * 3)
logging.debug(' '.join(cmd))
proc = subprocess.Popen(
cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
@@ -124,6 +126,8 @@ class TraceTestCases(unittest.TestCase):
r'',
r'\d+\.\ds Done post-processing logs\. Parsing logs\.',
r'\d+\.\ds Done parsing logs\.',
+ r'\d+.\ds Done stripping root\.',
+ r'\d+.\ds Done flattening\.',
r'',
])
self.assertTrue(re.match('^%s$' % expected_out_re, out), repr(out))
« no previous file with comments | « tools/isolate/trace_test_cases.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698